Skip to content

Handle IpseckeyGateway::None branch in hash impl - #706

Open
SebastiaanYN wants to merge 1 commit into
NLnetLabs:mainfrom
SebastiaanYN:ipseckeygateway
Open

Handle IpseckeyGateway::None branch in hash impl#706
SebastiaanYN wants to merge 1 commit into
NLnetLabs:mainfrom
SebastiaanYN:ipseckeygateway

Conversation

@SebastiaanYN

@SebastiaanYN SebastiaanYN commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Replace the hand-written hash implementation with #[derive(Hash)] to remove the todo!() from the None branch.

@SebastiaanYN SebastiaanYN changed the title Hnadle IpseckeyGateway::None branch in hash impl Handle IpseckeyGateway::None branch in hash impl Jul 27, 2026
@partim

partim commented Aug 10, 2026

Copy link
Copy Markdown
Member

I think IpseckeyGateway needs to hash safely on its own without relying on information from Ipseckey. This means that the current implementation is also broken. I suspect we can just derive Hash?

Replace the hand-written hash implementation with `#[derive(Hash)]` to remove
the `todo!()` from the `None` branch.
@SebastiaanYN

Copy link
Copy Markdown
Contributor Author

Good point, that's a lot easier. I've updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants