[tsig] Implement deserialization for TSIG Key and Algorithm. - #701
Draft
withjannisNLnetLabs wants to merge 1 commit into
Draft
[tsig] Implement deserialization for TSIG Key and Algorithm.#701withjannisNLnetLabs wants to merge 1 commit into
withjannisNLnetLabs wants to merge 1 commit into
Conversation
withjannisNLnetLabs
force-pushed
the
tsig-deserialize
branch
3 times, most recently
from
July 20, 2026 13:38
ddd9267 to
5abc706
Compare
withjannisNLnetLabs
marked this pull request as ready for review
July 20, 2026 13:42
Additionally a test containing an example TSIG key (in yaml format) which validates the functionality. See issue #695.
withjannisNLnetLabs
force-pushed
the
tsig-deserialize
branch
from
July 31, 2026 10:10
5abc706 to
2d3aa3c
Compare
withjannisNLnetLabs
marked this pull request as draft
August 3, 2026 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to parse a TSIG key from YAML. It implements the
serde::Deserializetrait fortsig::Keyandtsig::Algorithm. Both implementations are behind theserdefeature flag.resolves #695