Skip to content

[new] move DNS constants to macro implementation #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
withjannisNLnetLabs wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[new] move DNS constants to macro implementation #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98eaa3f
[new] Add docs to `CharStr` `PartialEq`
withjannisNLnetLabs Jul 9, 2026
0da66ad
[new] Add macro for DNS constants implementation
withjannisNLnetLabs Jul 9, 2026
b71d723
[new] Move R & Q Type/Class to macro impl
withjannisNLnetLabs Jul 9, 2026
8384bdf
[new] Move `SecAlg` to macro impl
withjannisNLnetLabs Jul 9, 2026
dba6d51
[new] Move `Nsec3HashAlgorithm` to macro impl
withjannisNLnetLabs Jul 9, 2026
8fc1803
[new] Move `ZoneMDScheme` to macro impl
withjannisNLnetLabs Jul 10, 2026
22c764e
[new] Move `ZoneMDHashAlg` to macro impl
withjannisNLnetLabs Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/new/base/charstr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@ impl Clone for alloc::boxed::Box<CharStr> {

//--- Equality

/// [Section 2.3.3 of RFC1035] (Character Case) states:
///
/// > For all parts of the DNS that are part of the official protocol, all
/// > comparisons between character strings (e.g., labels, domain names, etc.)
/// > are done in a case-insensitive manner.
///
/// [Section 2.3.3 of RFC1035]: https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.3
impl PartialEq for CharStr {
fn eq(&self, other: &Self) -> bool {
self.octets.eq_ignore_ascii_case(&other.octets)
Expand Down
Loading