Include DNSSEC records in the loaded zone when compacting. (fixes #960) - #961
Merged
ximon18 merged 1 commit intoAug 13, 2026
Conversation
bal-e
approved these changes
Aug 13, 2026
ximon18
deleted the
960-ixfr-diff-cannot-be-applied-after-compaction-and-restore-with-signed-upstream
branch
August 13, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested manually with the signed upstream case that originally caused me to create #960.
This PR does NOT extend the integration tests to cover the signed upstream -> compact -> restart -> restore -> IXFR update case which this fixes as I wanted to first unblock the latest release. I'll create a separate tracking issue for extending the tests to cover this case.
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?