Split out policy file (de)serialization to a subcrate - #935
Merged
Conversation
bal-e
force-pushed
the
policy-file-subcrate
branch
2 times, most recently
from
July 31, 2026 14:59
f0ab9df to
28e84a0
Compare
bal-e
force-pushed
the
policy-file-subcrate
branch
from
July 31, 2026 15:01
28e84a0 to
92ae3fe
Compare
ximon18
reviewed
Aug 7, 2026
Member
|
Other than the |
Member
|
LGTM: Maybe @Philip-NLnetLabs should look at the way fields have been renamed and moved around? |
ximon18
approved these changes
Aug 7, 2026
Member
|
I see some minor changes that should be fine. Maybe I missed something. @ximon18 anything specific? |
Member
No, just that in the past you have identified changes in policy field names or how policy is structured that you thought should be different so I thought it was to have you take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for #684 to programmatically create and adjust policy files.
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?