Open
Conversation
- Move distribution_schema.sql into src/gdm/db/ so it ships with the package and is available in CI (fixes FileNotFoundError). - Add gitignore exception for the bundled schema file. - Extract _delete_distribution_tables and _write_distribution_buses from _write_distribution_topology to reduce cyclomatic complexity. - Extract _load_or_cache_capacitor_equipment and _build_capacitor_controller from _load_distribution_capacitors_from_normalized. - Replace bare except/continue with loguru debug logging (B112).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
Checklist