Skip to content

Conversation

@amit-k-umar
Copy link

No description provided.

@AdityaPratap006
Copy link
Contributor

I reviewed your PR and would like to point out some things:

  1. Write the CSS of every component or screen in their separate files, instead of putting all the CSS in app.css, it will look cleaner that way.

  2. You had to create a launch detail screen for a particular launch, so before listing all the launches, there's no point in making the launch detail screen :)

And from now on, make the pull request to "amit-k-kumar-PR" branch and not the "master" branch.

@AdityaPratap006 AdityaPratap006 marked this pull request as draft October 6, 2020 14:32
@AdityaPratap006 AdityaPratap006 marked this pull request as ready for review October 6, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants