test: add leaf biophysics pFUnit unit test suite#1589
Open
johnpaulalex wants to merge 1 commit into
Open
Conversation
Add unit tests for LeafBiophysicsMod covering: - QSat: saturation vapor pressure and specific humidity - StomatalCondMedlyn and StomatalCondBallBerry: stomatal conductance - LowstorageMainRespReduction: low-storage maintenance respiration scaling - LeafLayerMaintenanceRespiration_Ryan_1991 and _Atkin_etal_2017: temperature-dependent respiration - GetCanopyGasParameters: Michaelis-Menten CO2/O2 temperature scaling Integrate the new suite into CMakeLists.txt and testing/config/unit.cfg so it is picked up by run_unit_tests.py.
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
Contributor
|
Thanks for the submissions @johnpaulalex |
rgknox
reviewed
Jul 16, 2026
|
|
||
| ! tol: near the 64-bit float representational limit; inline tolerances used where | ||
| ! hand-calculated values warrant lower precision (e.g. 1.e-6_r8). | ||
| real(r8), parameter :: tol = 1.e-13_r8 |
Contributor
There was a problem hiding this comment.
We actually need to start migrating to using this constant in more of the models internal code.
rgknox
added
testing: pure B4B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(not planning to submit yet, just want to start a discussion)
Add unit tests for LeafBiophysicsMod covering:
Integrate the new suite into CMakeLists.txt and testing/config/unit.cfg so it is picked up by run_unit_tests.py.
Description:
Collaborators:
Expectation of Answer Changes:
Description of generative AI usage (as necessary)
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: