Skip to content

allocate space to disturbance_rates in the restart file#1588

Merged
rgknox merged 1 commit into
NGEET:mainfrom
rgknox:restart_distrates
Jul 23, 2026
Merged

allocate space to disturbance_rates in the restart file#1588
rgknox merged 1 commit into
NGEET:mainfrom
rgknox:restart_distrates

Conversation

@rgknox

@rgknox rgknox commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description:

For FATES variables that are restarted, and are longer than column level (ie most of our variables), we end up folding all of these variables into a restart vector of one prescribed length. We call this the cohort dimension, but it really is a catch all for any variable that requires more space than the site/column. So, the size of this vector must be the largest possible vector that we need to remember. We have some tricks to get around making this vector super large, one of them is to actually define multiple copies of the variable with name extensions.
But its very important when we add new restart variables that are big, that we make sure we allocate restart space. Its hard to know which dimensions are going to require the most restart space, because many of things are modified by the user, and contextual to the type of run.

This set of changes makes sure that we allocate enough restart space for "disturbance_rates" which is a 3D variable (n_landuse_cats x n_landuse_cats * n_dist_type = 5 * 5 * 4 = 100)

I came across this while reviewing one of @mpaiao 's old PRs.

cc: @mvdebolskiy @maritsandstad @JessicaNeedham @rosiealice

(I'm not sure if this is affecting noresm nocomp lu runs, seems possible though)

Collaborators:

@mpaiao

Expectation of Answer Changes:

Description of generative AI usage (as necessary)

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox
rgknox merged commit ef412b7 into NGEET:main Jul 23, 2026
1 check was pending
@github-project-automation github-project-automation Bot moved this from Finding Reviewers to Ready to Integrate in FATES Pull Request Planning and Status Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to Integrate

Development

Successfully merging this pull request may close these issues.

1 participant