Skip to content

655 subject headings edit abilities#709

Open
SonAndrea wants to merge 3 commits intomainfrom
655-subject-headings-edit-abilities
Open

655 subject headings edit abilities#709
SonAndrea wants to merge 3 commits intomainfrom
655-subject-headings-edit-abilities

Conversation

@SonAndrea
Copy link
Copy Markdown
Collaborator

Added functionality for editors to add new subject headings and add from existing ones.

@SonAndrea SonAndrea linked an issue Apr 8, 2026 that may be closed by this pull request
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 8, 2026

Deploy Preview for dailp ready!

Name Link
🔨 Latest commit 0363012
🔍 Latest deploy log https://app.netlify.com/projects/dailp/deploys/69f120fb9063570008566cef
😎 Deploy Preview https://deploy-preview-709--dailp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chullings chullings requested a review from alisony755 April 15, 2026 17:20
Copy link
Copy Markdown
Collaborator

@alisony755 alisony755 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! There might be a minor issue with the subject headings updating the dropdown after the form is submitted if that's what's intended

style={{ color: "#666", fontStyle: "italic", padding: "8px" }}
>
No subject headings found in database.
</div>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a message for when there are no subject headings is a good addition!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider making the new custom subject headings blue to match the styling of the other input fields

}
}
setNewSubjectName("")
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I noticed is that if I submit a new subject heading and reopen the modal, the new subject heading will not be included in the subject headings for the document or in the dropdown of existing subject headings

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this again with an editor account! The subject headings do update for the document after the form is submitted. If I submit a subject heading for one document, that subject heading will not be included in the dropdown for another document. If not sure if that's the intended functionality though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subject Headings edit abilities

2 participants