-
Notifications
You must be signed in to change notification settings - Fork 53
DRAFT (NOT READY FOR REVIEW) Feature/capgen #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e as the module, which was causing problems in Capgen where flat-fields are passed from the API to the suite caps (e.g. the argument lsm_noah is now a problem in the lsm_noah module, when GFS_control%lsm_noah was not a conflict
…itial tracer setup to gfs_control_type
|
@dustinswales It's possible that we can cut the number of suites in half for the SCM by implementing the prescribed surface fluxes differently (as discussed in past meetings). Basically, we'd change all suites to run through the surface calculations, but insert a group end after the surface schemes to return back to the SCM code to either replace the surface fluxes or use the ones calculated in physics. This might be a good opportunity to clean this up (and we can implement the 'beta' surface forcing method at the same time). This would at least speed up capgen by reducing the number of suites organically, although it isn't necessarily a long term solution because we'd like to be able to use as many suites as necessary for SCM RTs since it's at least faster and less computationally intensive than UFS! |
@grantfirl I support the idea of getting rid of the _ps SDFs. I think I follow what you are proposing. |
SOURCE: Developer's name and affiliation
DESCRIPTION OF CHANGES:
scm/docif needed.ISSUE: # Enter GitHub Issue number after
#ASSOCIATED PRs:
TESTS CONDUCTED: List tests done as appropriate. Delete if not used.
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated fv3atm PR:
Associated NCAR PR:
REGRESSION TEST CHANGES: Enter NONE if not applicable. Otherwise, expected results changes, input data changes, changes to the software, etc.