Skip to content

feat(download): v2 file download via /files/{fileId} #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhagberg wants to merge 9 commits into
base: feat/v2-full-list
Choose a base branch
from
Open

feat(download): v2 file download via /files/{fileId} #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
96b4a21
feat(apiclient): DownloadFile signature on Client
jhagberg Apr 22, 2026
6ffe7e5
feat(apiclient): V1Client.DownloadFile
jhagberg Apr 22, 2026
bf38260
feat(apiclient): V2Client.DownloadFile
jhagberg Apr 22, 2026
e44df43
refactor(download): command uses apiclient.Client directly
jhagberg Apr 22, 2026
637226b
test(integration): end-to-end v2 download test
jhagberg Apr 22, 2026
ccc13b5
refactor(downloadclient): carry forward #679/#681 review-amend fallout
jhagberg May 13, 2026
5d384e0
refactor(downloadclient): unexport File.DownloadURL → downloadURL
jhagberg May 26, 2026
e1db5b3
fix(downloadclient): drop redundant json tag on unexported downloadURL
jhagberg May 26, 2026
f5bc665
refactor(downloadclient): address PR review feedback from #686
jhagberg May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/integration-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,20 @@ jobs:
echo "::add-mask::$TOKEN"
echo "TOKEN=$TOKEN" >> "$GITHUB_OUTPUT"

- name: Extract c4gh pubkey
id: pubkey
run: |
docker compose --project-name download-v2-dev cp reencrypt:/shared/c4gh.pub.pem ./c4gh.pub.pem
KEY=$(base64 -w0 ./c4gh.pub.pem)
echo "::add-mask::$KEY"
echo "KEY=$KEY" >> "$GITHUB_OUTPUT"

- name: Run v2 integration tests
working-directory: sda-cli
env:
DOWNLOAD_V2_URL: http://localhost:8085
DOWNLOAD_V2_TOKEN: ${{ steps.token.outputs.TOKEN }}
DOWNLOAD_V2_PUBKEY_B64: ${{ steps.pubkey.outputs.KEY }}
run: |
go test -tags=integration -v ./...

Expand Down
Loading
Loading