Skip to content

[TASK] Raise PHPStan to level 4 #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

[TASK] Raise PHPStan to level 4 #1201

merged 1 commit into from
Jul 11, 2025

Conversation

oliverklee
Copy link
Collaborator

Also allow assertInstanceOf checks in the tests (as we find those useful).

@oliverklee oliverklee self-assigned this Mar 19, 2025
@oliverklee oliverklee marked this pull request as draft March 19, 2025 21:38
@coveralls
Copy link

coveralls commented Mar 19, 2025

Coverage Status

coverage: 58.906%. remained the same
when pulling 5cd3bef on task/phpstan-level-4
into 6a7d412 on main.

@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 5 times, most recently from 6ce2e97 to 3509d29 Compare March 26, 2025 13:10
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch from 3509d29 to b33a1ae Compare April 1, 2025 08:21
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 4 times, most recently from 27b563b to 2d2ac6f Compare May 4, 2025 08:25
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 3 times, most recently from da16781 to d044192 Compare May 10, 2025 08:33
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch from d044192 to ed9880e Compare May 22, 2025 08:07
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 2 times, most recently from 6d1f9f9 to 41683a0 Compare June 11, 2025 13:17
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 3 times, most recently from 2784bc9 to c0fdca3 Compare June 26, 2025 16:07
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 4 times, most recently from d717773 to 6f5219a Compare July 4, 2025 13:13
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch 2 times, most recently from 1df3121 to fd5b2b3 Compare July 10, 2025 12:06
Also allow `assertInstanceOf` checks in the tests (as we find
those useful).
@oliverklee oliverklee force-pushed the task/phpstan-level-4 branch from fd5b2b3 to 5cd3bef Compare July 11, 2025 16:46
@oliverklee oliverklee marked this pull request as ready for review July 11, 2025 16:46
@oliverklee oliverklee requested a review from JakeQZ July 11, 2025 16:46
@oliverklee
Copy link
Collaborator Author

Let's get this in before the 9.0 release.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be picking up quite a few tautologies, though I think we should keep the various asserts in place, even if they will 'obviously' pass.

It might also be good to resolve some of the PHPStan warnings before releasing 9.0. There is no great rush for this release; I just don't want to backport any more to 8.x (PHP<7.2 is surely history now).

@JakeQZ JakeQZ merged commit b6b8ecf into main Jul 11, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/phpstan-level-4 branch July 11, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants