[TASK] Raise PHPStan to level 4 #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/phpstan-level-4
branch
5 times, most recently
from
6ce2e97 to
3509d29
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
from
3509d29 to
b33a1ae
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
4 times, most recently
from
27b563b to
2d2ac6f
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
3 times, most recently
from
da16781 to
d044192
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
from
d044192 to
ed9880e
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
2 times, most recently
from
6d1f9f9 to
41683a0
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
3 times, most recently
from
2784bc9 to
c0fdca3
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
4 times, most recently
from
d717773 to
6f5219a
Compare
oliverklee
force-pushed
the
task/phpstan-level-4
branch
2 times, most recently
from
1df3121 to
fd5b2b3
Compare
Also allow `assertInstanceOf` checks in the tests (as we find those useful).
oliverklee
force-pushed
the
task/phpstan-level-4
branch
from
fd5b2b3 to
5cd3bef
Compare
|
Let's get this in before the 9.0 release. |
JakeQZ
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
It seems to be picking up quite a few tautologies, though I think we should keep the various asserts in place, even if they will 'obviously' pass.
It might also be good to resolve some of the PHPStan warnings before releasing 9.0. There is no great rush for this release; I just don't want to backport any more to 8.x (PHP<7.2 is surely history now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow
assertInstanceOfchecks in the tests (as we find those useful).