-
Notifications
You must be signed in to change notification settings - Fork 146
[TASK] Raise PHPStan to level 4 #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ce2e97
to
3509d29
Compare
3509d29
to
b33a1ae
Compare
27b563b
to
2d2ac6f
Compare
da16781
to
d044192
Compare
d044192
to
ed9880e
Compare
6d1f9f9
to
41683a0
Compare
2784bc9
to
c0fdca3
Compare
d717773
to
6f5219a
Compare
1df3121
to
fd5b2b3
Compare
Also allow `assertInstanceOf` checks in the tests (as we find those useful).
fd5b2b3
to
5cd3bef
Compare
Let's get this in before the 9.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be picking up quite a few tautologies, though I think we should keep the various assert
s in place, even if they will 'obviously' pass.
It might also be good to resolve some of the PHPStan warnings before releasing 9.0. There is no great rush for this release; I just don't want to backport any more to 8.x (PHP<7.2 is surely history now).
Since #1201, this becomes a duplicate.
Since #1201, this becomes a duplicate.
Also allow
assertInstanceOf
checks in the tests (as we find those useful).