Skip to content

MCR-3645 Refactor Solr Integration to Use Configurable Class Instance…#2862

Closed
sebhofmann wants to merge 7 commits intomainfrom
issues/mcr-3645-refactor_solr_integration_to_use_configurable_class_instances_(mcrsolrindexmanager)
Closed

MCR-3645 Refactor Solr Integration to Use Configurable Class Instance…#2862
sebhofmann wants to merge 7 commits intomainfrom
issues/mcr-3645-refactor_solr_integration_to_use_configurable_class_instances_(mcrsolrindexmanager)

Conversation

@sebhofmann
Copy link
Member

@sebhofmann sebhofmann commented Mar 17, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

}

protected Set<MCRIndexType> buildCoreTypes() {
return Stream.of(coreTypes.split(","))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties containing comma-separated lists of values should be split with MCRConfiguration2::splitValue for consistent edge-case-behavior.

... or wait for #2855 and use @MCRPropertyList to inject List<String>-values.

Same for zkUrls and solrUls in MCRConfigurableSolrCloudCollection.ConfigAdapter and probably others.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that.

@sebhofmann sebhofmann closed this Mar 17, 2026
@sebhofmann sebhofmann deleted the issues/mcr-3645-refactor_solr_integration_to_use_configurable_class_instances_(mcrsolrindexmanager) branch March 17, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants