Skip to content

MCR-3646 Harmonize edge cases and improve error and log messages of annotation based configuration#2861

Open
toKrause wants to merge 1 commit intomainfrom
issues/MCR-3646_Harmonize-edge-cases-and-improve-error-and-log-messages-of-annotation-based-configuration
Open

MCR-3646 Harmonize edge cases and improve error and log messages of annotation based configuration#2861
toKrause wants to merge 1 commit intomainfrom
issues/MCR-3646_Harmonize-edge-cases-and-improve-error-and-log-messages-of-annotation-based-configuration

Conversation

@toKrause
Copy link
Contributor

@toKrause toKrause commented Mar 17, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Behavior of some edge cases changes. See ticket for complete list. Migration guide follows.

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

See ticket. Code contains exhaustive list of tests cases.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@toKrause toKrause requested a review from yagee-de March 17, 2026 12:02
@toKrause toKrause force-pushed the issues/MCR-3646_Harmonize-edge-cases-and-improve-error-and-log-messages-of-annotation-based-configuration branch 4 times, most recently from 25ca6f5 to 8fd24c1 Compare March 19, 2026 15:40
@toKrause toKrause force-pushed the issues/MCR-3646_Harmonize-edge-cases-and-improve-error-and-log-messages-of-annotation-based-configuration branch 2 times, most recently from 97f85d9 to 8d1f497 Compare March 20, 2026 17:59
@toKrause toKrause force-pushed the issues/MCR-3646_Harmonize-edge-cases-and-improve-error-and-log-messages-of-annotation-based-configuration branch 4 times, most recently from e6305b2 to df336cb Compare March 25, 2026 13:23
@toKrause toKrause force-pushed the issues/MCR-3646_Harmonize-edge-cases-and-improve-error-and-log-messages-of-annotation-based-configuration branch from df336cb to 670c0ab Compare March 26, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant