Skip to content

MIR-1511 revise accessibility requirements #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
obgit wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

MIR-1511 revise accessibility requirements #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f918a84
first accessibilty Changes on 25main
obgit Jun 23, 2025
0be11d7
accessibilty
obgit May 15, 2025
07bf911
accessibility_issues_solve_merge_conflict
obgit Jun 20, 2025
1c83736
Stable accessibility version with 25main. Todos: aria-label-texts in …
obgit Jun 24, 2025
39dbecc
fix error in issue
obgit Jan 22, 2026
2a0870a
Merge branch 'main' into issues/MIR-1511-revise_accessibility_require…
obgit Feb 3, 2026
4501ed0
Merge remote-tracking branch 'origin/main' into issues/MIR-1511-revis…
obgit Feb 3, 2026
6870068
Fix accessibility issue in new added scope "project information"
obgit Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified mir-cli/src/main/bin/setup.sh
100755 → 100644
View file
Open in desktop
Empty file.
6 changes: 3 additions & 3 deletions mir-layout/src/main/resources/META-INF/resources/bootswatch-default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ <h1 id="navbar">Navbar</h1>
<li><a href="#">Link</a></li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-expanded="false">Dropdown <span class="caret"></span></a>
<ul class="dropdown-menu" role="menu">
<ul class="dropdown-menu">
<li><a href="#">Action</a></li>
<li><a href="#">Another action</a></li>
<li><a href="#">Something else here</a></li>
Expand Down Expand Up @@ -181,7 +181,7 @@ <h1 id="navbar">Navbar</h1>
<li><a href="#">Link</a></li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-expanded="false">Dropdown <span class="caret"></span></a>
<ul class="dropdown-menu" role="menu">
<ul class="dropdown-menu">
<li><a href="#">Action</a></li>
<li><a href="#">Another action</a></li>
<li><a href="#">Something else here</a></li>
Expand Down Expand Up @@ -1272,7 +1272,7 @@ <h4 class="modal-title">Source Code</h4>
</div>


<script type="text/javascript" src="webjars/jquery/1.11.3/jquery.min.js"></script>
<script src="webjars/jquery/1.11.3/jquery.min.js"></script>
<script src="../bower_components/bootstrap/dist/js/bootstrap.min.js"></script>
<script src="../assets/js/bootswatch.js"></script>
</body>
Expand Down
6 changes: 3 additions & 3 deletions mir-layout/src/main/resources/META-INF/resources/mir-layout/template/flatmir.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</ul>
<form class="d-flex">
<input class="form-control me-sm-2" type="search" placeholder="Search" />
<button class="btn btn-secondary my-2 my-sm-0" type="submit">Search</button>
<button aria-label="Search" class="btn btn-secondary my-2 my-sm-0" type="submit">Search</button>
</form>
</div>
</div>
Expand Down Expand Up @@ -104,7 +104,7 @@
</ul>
<form class="d-flex">
<input class="form-control me-sm-2" type="search" placeholder="Search" />
<button class="btn btn-secondary my-2 my-sm-0" type="submit">Search</button>
<button aria-label="Search button" class="btn btn-secondary my-2 my-sm-0" type="submit">Search</button>
</form>
</div>
</div>
Expand Down Expand Up @@ -148,7 +148,7 @@
</ul>
<form class="d-flex">
<input class="form-control me-sm-2" type="search" placeholder="Search" />
<button class="btn btn-secondary my-2 my-sm-0" type="submit">Search</button>
<button aria-label="Search button" class="btn btn-secondary my-2 my-sm-0" type="submit">Search</button>
</form>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions mir-layout/src/main/resources/META-INF/resources/template-chooser.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<section xml:lang="de" title="Layout wechseln">
<h1>Template Chooser</h1>
<div class="row">
<form role="form" method="post" name="templateChooser" class="form-horizontal col-sm-5">
<form method="post" name="templateChooser" class="form-horizontal col-sm-5">
<div class="form-group">
<label for="layout" class="col-sm-6 control-label">Layout β</label>
<div class="col-sm-6">
Expand Down Expand Up @@ -65,7 +65,7 @@
}
]]>
</style>
<script type="text/javascript">
<script>
<![CDATA[
"use strict";
(function($) {
Expand Down
6 changes: 3 additions & 3 deletions mir-layout/src/main/resources/xsl/mir-cosmol-layout-utils.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
</xsl:choose>
<div class="input-group mb-3">
<div class="input-group-append">
<button type="submit" class="btn btn-primary">
<button type="submit" aria-label="Search" class="btn btn-primary">
<i class="fas fa-search"></i>
</button>
</div>
Expand Down Expand Up @@ -110,8 +110,8 @@
<div class="col-2">
<h4>Netzwerke</h4>
<ul class="social_links">
<li><a href="#"><button type="button" class="social_icons social_icon_fb"></button>Facebook</a></li>
<li><a href="#"><button type="button" class="social_icons social_icon_x"></button>X</a></li>
<li><button type="button" aria-label="Facebook" class="social_icons social_icon_fb" onclick="window.open('https://facebook.com', '_blank')">Twitter</button></li>
<li><button type="button" aria-label="X" class="social_icons social_icon_x" onclick="window.open('https://twitter.com', '_blank')">X</button></li>
</ul>
</div>
<div class="col-2">
Expand Down
2 changes: 1 addition & 1 deletion mir-layout/src/main/resources/xsl/mir-cosmol-layout.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<script src="{$WebApplicationBaseURL}mir-layout/assets/jquery/plugins/jquery-migrate/jquery-migrate.min.js"></script>
<xsl:copy-of select="head/*" />
<link href="{$WebApplicationBaseURL}rsc/sass/mir-layout/scss/{$MIR.Layout.Theme}-{$MIR.DefaultLayout.CSS}.css" rel="stylesheet" />
<script type="text/javascript" src ="{$WebApplicationBaseURL}mir-layout/js/cosmol.js"></script>
<script src ="{$WebApplicationBaseURL}mir-layout/js/cosmol.js"></script>
<xsl:if test="string-length($MIR.CustomLayout.CSS) &gt; 0">
<link href="{$WebApplicationBaseURL}css/{$MIR.CustomLayout.CSS}" rel="stylesheet" />
</xsl:if>
Expand Down
6 changes: 3 additions & 3 deletions mir-layout/src/main/resources/xsl/mir-flatmir-layout-utils.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
</xsl:when>
</xsl:choose>

<button type="submit" class="btn btn-primary my-2 my-sm-0">
<button type="submit" aria-label="Search" class="btn btn-primary my-2 my-sm-0">
<i class="fas fa-search"></i>
</button>
</form>
Expand Down Expand Up @@ -149,8 +149,8 @@
<div class="col-2">
<h4>Netzwerke</h4>
<ul class="social_links">
<li><a href="#"><button type="button" class="social_icons social_icon_fb"></button>Facebook</a></li>
<li><a href="#"><button type="button" class="social_icons social_icon_x"></button>X</a></li>
<li><button type="button" aria-label="Facebook" class="social_icons social_icon_fb" onclick="window.open('https://facebook.com', '_blank')">Facebook</button></li>
<li><button type="button" aria-label="X" class="social_icons social_icon_x" onclick="window.open('https://x.com', '_blank')">X</button></li>
</ul>
</div>
<div class="col-2">
Expand Down
2 changes: 1 addition & 1 deletion mir-module/src/main/resources/META-INF/resources/authorization/new-author-includes.xed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<xed:template id="captcha">
<xed:if test="string-length($MIR.ReCaptcha.site.key) &gt; 0">
<script src='https://www.google.com/recaptcha/api.js' />
<script type="text/javascript">
<script>
<![CDATA[
var verifyCallback = function(response) {
$('#my-g-recaptcha-response').val(response);
Expand Down
18 changes: 8 additions & 10 deletions mir-module/src/main/resources/META-INF/resources/content/publish/index.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

<form id="submit_publication"
class="form-horizontal"
role="form"
method="get"
action="../../editor/editor-dynamic.xed">

Expand All @@ -30,7 +29,7 @@

<div class="row mir-form-group">
<label for="genre" class="col-sm-3 col-lg-2 control-label form-label">
<text i18n="component.mods.genre" />
Publikationstyp
</label>
<div class="col-sm-7 col-md-5 col-lg-4">
<select id="genre" class="form-control form-select" name="genre" size="1">
Expand All @@ -40,7 +39,7 @@

<div class="row mir-form-group">
<label for="host" class="col-sm-3 col-lg-2 control-label form-label">
<text i18n="mir.select.host" />
erschienen in:
</label>
<div class="col-sm-7 col-md-5 col-lg-4">
<select id="host" class="form-control form-select" name="host" size="1">
Expand All @@ -58,7 +57,7 @@

<div class="row mir-form-group">
<div class="col-sm-3 col-lg-2 control-label">
<select name="type" class="form-control form-select">
<select aria-label="Andere Datenquelle auswählen" name="type" class="form-control form-select">
<option value="doi">DOI</option>
<option value="scopus">Scopus-ID</option>
<option value="pubmed">PubMed-ID</option>
Expand All @@ -70,7 +69,7 @@
</select>
</div>
<div class="col-sm-7 col-md-5 col-lg-4">
<input class="form-control" type="text" name="modsId" />
<input aria-label="Eingabefeld für mods ID" class="form-control" type="text" name="modsId" />
</div>
</div>

Expand All @@ -89,7 +88,6 @@

<form id="submit_publication"
class="form-horizontal"
role="form"
method="get"
action="../../editor/editor-dynamic.xed">

Expand All @@ -109,7 +107,7 @@

<div class="row mir-form-group">
<label for="genre" class="col-sm-3 col-lg-2 control-label form-label">
<text i18n="component.mods.genre" />
Type of the publication
</label>
<div class="col-sm-7 col-md-5 col-lg-4">
<select id="genre" class="form-control form-select" name="genre" size="1">
Expand All @@ -119,7 +117,7 @@

<div class="row mir-form-group">
<label for="host" class="col-sm-3 col-lg-2 control-label form-label">
<text i18n="mir.select.host" />
appears in:
</label>
<div class="col-sm-7 col-md-5 col-lg-4">
<select id="host" class="form-control form-select" name="host" size="1">
Expand All @@ -137,7 +135,7 @@

<div class="row mir-form-group">
<div class="col-sm-3 col-lg-2 control-label">
<select name="type" class="form-control form-select">
<select aria-label="select a mods typ" name="type" class="form-control form-select">
<option value="doi">DOI</option>
<option value="scopus">Scopus-ID</option>
<option value="pubmed">PubMed-ID</option>
Expand All @@ -149,7 +147,7 @@
</select>
</div>
<div class="col-sm-7 col-md-5 col-lg-4">
<input class="form-control" type="text" name="modsId" />
<input aria-label="input field for mods ID" class="form-control" type="text" name="modsId" />
</div>
</div>

Expand Down
14 changes: 7 additions & 7 deletions mir-module/src/main/resources/META-INF/resources/content/search/complex.xed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<section xml:lang="all" xmlns:xed="http://www.mycore.de/xeditor" xmlns:mir="http://www.mycore.de/mir"
i18n="component.mods.editor.search.complex.pagetitle">
<xed:form class="form-horizontal" role="form">
<xed:form class="form-horizontal">
<xed:cleanup-rule xpath="//condition" relevant-if="(string-length(@value) &gt; 0) or value[string-length(text()) &gt; 0 ]" />
<xed:cleanup-rule xpath="//boolean" relevant-if="boolean|condition" />
<xed:cleanup-rule xpath="//condition[@selectable='true']" relevant-if="@id = ../selectCondition/@keep" />
Expand All @@ -39,7 +39,7 @@
<div class="mir-form-group row">
<div class="col-md-3">
<xed:bind xpath="@field">
<select class="form-control form-select">
<select aria-label="select search ident" class="form-control form-select">
<option value="mods.title">
<xed:output i18n="editor.search.mir.title" />
</option>
Expand All @@ -57,7 +57,7 @@
</div>
<div class="col-md-2">
<xed:bind xpath="@operator">
<select class="form-control form-select">
<select aria-label="select serch operator" class="form-control form-select">
<option value="contains">
<xed:output i18n="editor.search.contains" />
</option>
Expand All @@ -73,7 +73,7 @@
<div class="col-md-7 row">
<div class="col-md-8">
<xed:bind xpath="@value">
<input type="text" class="form-control" />
<input aria-label="input field" type="text" class="form-control" />
</xed:bind>
</div>
<div class="btn-group col-md-4">
Expand Down Expand Up @@ -116,7 +116,7 @@
</label>
<div class="col-md-2">
<xed:bind xpath="@operator">
<select class="form-control form-select">
<select aria-label="select operator" class="form-control form-select">
<option value="=">=</option>
<option value="&gt;">&gt;</option>
<option value="&gt;=">&gt;=</option>
Expand Down Expand Up @@ -171,7 +171,7 @@
</label>
<div class="col-md-4">
<xed:bind xpath="@name">
<select class="form-control form-select">
<select id="inputSortBy" class="form-control form-select">
<option value="mods.dateIssued">
<xed:output i18n="component.mods.metaData.dictionary.dateIssued" />
</option>
Expand All @@ -183,7 +183,7 @@
</div>
<div class="col-md-3">
<xed:bind xpath="@order">
<select class="form-control form-select">
<select aria-label="select order" class="form-control form-select">
<option value="descending">
<xed:output i18n="editor.search.descending" />
</option>
Expand Down
Loading
Loading