Add C & Fortran Wrappers for new linear temporal sampler.#113
Open
blairSmcc03 wants to merge 2 commits intoMxUI:masterfrom
Open
Add C & Fortran Wrappers for new linear temporal sampler.#113blairSmcc03 wants to merge 2 commits intoMxUI:masterfrom
blairSmcc03 wants to merge 2 commits intoMxUI:masterfrom
Conversation
- Add temporal_sampler_linear typedef, create, destroy, and fetch functions to C wrapper (mui_c_wrapper_1d/2d/3d.h and .cpp) - Add temporal_sampler_linear bindings to Fortran wrapper (mui_f_wrapper_1d/2d/3d.f90 and .cpp) - Add unit tests for linear temporal sampler in both C and Fortran wrappers (unit_test_single_linear.c, unit_test_multi_linear.c, unit_test_linear.f90, unit_test_multi_linear.f90) The linear temporal sampler uses dt_neighbour parameter for time interpolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that this code was written by Claude Code and reviewed by myself. I have run unit tests in C and Fortran for the new sampler which were successful. Please let me know if these should be included in the PR.