This repository was archived by the owner on Jul 11, 2018. It is now read-only.
Change LiveSigns task to JSON for working with PHP7#102
Open
SleepSpace9 wants to merge 2 commits intoMuirfield:masterfrom
SleepSpace9:LiveSigns-PHP7
Open
Change LiveSigns task to JSON for working with PHP7#102SleepSpace9 wants to merge 2 commits intoMuirfield:masterfrom SleepSpace9:LiveSigns-PHP7
SleepSpace9 wants to merge 2 commits intoMuirfield:masterfrom
SleepSpace9:LiveSigns-PHP7
Conversation
sanalika
approved these changes
Jun 16, 2018
sanalika
left a comment
sanalika
left a comment
There was a problem hiding this comment.
this works on 3.0.0-alpha12 php 7.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I switched to JSON encode/decode of the array, because serialize/unserialize didn't work with php7 and now it workes for me.