Update Google endpoints #451
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue where the old endpoints would return tokens with missing data when using the `id_token` response type. I pulled the newer versions from: https://accounts.google.com/.well-known/openid-configuration
With the newer Google endpoints, `id_token` response types require a `nonce` paramenter. This may not be necessary, because it doesn't look like OpenID Connect is officially supported here.
|
Hi thanks for submitting this... time ago FYI: There's an issue with updating this with the proxy server which needs to be resolved MrSwitch/node-oauth-shim#23 A |
|
Hi, Following deprecation of Google+ next year (see https://developers.google.com/+/api-shutdown) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where the old endpoints would return
tokens with missing data when using the
id_tokenresponsetype. I pulled the newer versions from:
https://accounts.google.com/.well-known/openid-configuration
With the newer Google endpoints,
id_tokenresponsetypes require a
nonceparamenter. This may not benecessary, because it doesn't look like OpenID Connect
is officially supported here.