GPX: Invoke _handleLayerMouseOver on the correct layer#54
Open
adg29 wants to merge 1 commit intoMrMufflon:masterfrom
Open
GPX: Invoke _handleLayerMouseOver on the correct layer#54adg29 wants to merge 1 commit intoMrMufflon:masterfrom
adg29 wants to merge 1 commit intoMrMufflon:masterfrom
Conversation
… a check for undefined layer to correctly assign the layer which triggers mouseover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the conditional
typeof layer==='undefined'. This ensures thatlayeris correctly assigned to thelineobject that is made available by theaddLinecallback in the GPX use-case. Previously there was only a check fornull, which prevented the correct assignment to the layer that is assigned the mouseover.With the correct assignment,
mouseoveris now triggered on thelineand the corresponding point in the elevation diagram is indicated.Tested on a GPX file @ http://codepen.io/adg29/full/jAzpRo/