Changes to help engine work with latest GFXT#1
Open
TimeTravelerFromNow wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Wanted to try the engine using a forked gunslinger, but realized the submodule for the engine is tied to a much older gunslinger commit. When I used the closer to latest fork, I ran into undefined functions. This PR mostly is updating the functions in the gs_engine to support the more up to date gunslinger.
Work in this PR
Had to make a few changes to GS for this to work together. See this branch. I'm working off of the branch which I used for the multiple cgltf node rendering, I can reorganize if we want to see a diff to main for the GS framework.
GS gui needed some color enum values.
Noticed that in
gs_core/source/gs_asset.hthere were many lines of code which exist in the GFXT util. I removed these, and changed the function calls in the gs_engine repository to play nicely with the latest GS.environment
Ubuntu 20.04.4 LTS, NVIDIA Corporation GP106 [GeForce GTX 1060 6GB], Intel® Core™ i5-4690K CPU @ 3.50GHz × 4
Unrelated
Seeing
gs_core/gs_component.h, was exciting! Got to glance by some of the component manager code by @MrFrenik. Very cool stuff