refactor(rendering): factor out MutableChunkMesh #4998
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things that made working on ChunkMeshWorker for #4987 scary was the concern that a ChunkMesh's data might be updated while it was in the middle of updating the mesh for OpenGL.
Upon closer examination, it looks like in practice that a new instance of ChunkMesh is created each time the chunk is dirtied. That means
Chunk.meshcould be a reference to a safer, non-mutable interface.I experimented with this (see attached 269f823), moving the methods
vertexElements,updateMeshanddisposeDatato a newMutableMeshinterface.Outstanding before merging
There are a few things that need to be addressed:
updateMeshanddiscardDataon its RenderableChunk. Should that change? Or is the LodChunkProvider code redundant with the ChunkMeshWorker code?update), but it really only updates the material. In fact, I see only one implementation of this, and it looks like it could be a static method.