[Port] Mapping Editor - Early Merge 'N Tweaks#3810
[Port] Mapping Editor - Early Merge 'N Tweaks#3810lexaSvarshik wants to merge 4 commits intoMonolith-Station:mainfrom
Conversation
* add layers menu and erase tile button * add fixgridatmos and rmgrid buttons * remove delete button * fix texture * add icons * move layers buttons to xaml * add move grid button * add secondary use cancel actions * add grid VV button and decales parents * add shaddow toggle button * idk what i do * add erase decal overlay * rename layers window to visibility window * rework editor ui layout * cleanup * better pick action overlay * add gallery layout for decals * unfuck fucking ui * better icons * fix gallery layout search * locale and rename stuff * add dical picker * fix * decal color pick * add decal switch on middle mouse * better bindings * fixes and cleanup * add use custom color button * fixes * add favorite objects list * add search for entities by prototype id * rename * add mapping objects templates * add pipes color action and decal rotation * fix escape menu in editor * add chat toggle button * save favorites objects locally * todo * update mappingclientsidesetup command * fix admin menu in editor * update mapping templates * add buttons tooltip * add palette for atmos pipes * comments and code cleanup * remove mapping overlay disabling on server * cleanup * fix decal pick bind * fix yaml linter * split pr into parts * fix null prototypes search * review * forgot * fix typecheck * hide HideSpawnMenu entities * add show/hide spawn lists button * open object tree on double click in search list * fix human-readable names for tiles * fix objects dublicating * webedit ops * Update MappingOverlay.cs * chore: Automatically update REUSE headers * chore: Automatically update REUSE headers * get everything working * chore: Automatically update REUSE headers * chore: Automatically update REUSE headers * whitespace * tags for mapping * tag fix * markings, comments and namespace * chore: Automatically update REUSE headers * mapping templates update part 1 * mapping templates update part 2 --------- Co-authored-by: poemota <142114334+poeMota@users.noreply.github.com> Co-authored-by: ReserveBot <211949879+ReserveBot@users.noreply.github.com>
github-actions
Bot
added
size/L
S: Untriaged
UI
C#
YML
FTL
and removed
S: Untriaged
labels
monolith8319
changed the title
|
needs to handle our shuttle stuff such as radar edge markers and non-square tiles well |
will do |
|
the original is MIT, so this should be licensed MIT as well (I just put it in the PR it works) |
|
good |
| private void OnMappingFavoritesSave(MappingFavoritesSaveMessage message) | ||
| { | ||
| var mapping = new MappingDataNode(); | ||
| mapping.Add("prototypes", _serialization.WriteValue(message.PrototypeIDs, notNullableOverride: true)); | ||
|
|
||
| var path = new ResPath(FavoritesPath); | ||
| using var writer = _resourceMan.UserData.OpenWriteText(path); | ||
| var stream = new YamlStream { new(mapping.ToYaml()) }; | ||
| stream.Save(new YamlMappingFix(new Emitter(writer)), false); | ||
| } | ||
|
|
||
| private void OnMappingFavoritesLoad(MappingFavoritesLoadMessage message) | ||
| { | ||
| var path = new ResPath(FavoritesPath); |
There was a problem hiding this comment.
those should either A) be gatekept by a cvar that enables/disables them and is false by default but true in devenv (there's a devenv config file) B) check admin perms on the sender
currently those could be used on live server to take up disk space
There was a problem hiding this comment.
i don't think russian locale is needed?
There was a problem hiding this comment.
i didnt look at the code but!
Mandatory:
- The mirrored arrow has a ERROR sign (probably a sprite error)
- All radar marking showcase sprites are the same, it can be confusing
Suggestions:
-
Visualiser of multitool connections (what machine/door is connected to other machines/doors/buttons, ect)
-
add a mass scanner ability button to check the ship out on mass overview
- Try to make the text not get cut off so instead of it just dissapearing into the ather it would do this instead:
Airlock
Exterior,Locked
- The middle mouse rotate should pick the north,south,east,west version of the decals to prevent the missalignment and other visual inconsistencies
UnicornOnLSD
left a comment
UnicornOnLSD
left a comment
There was a problem hiding this comment.
Tested it myself, I'll only mentions issues I have for the sake of efficiency:
-
The color hexer is broken, I cannot input the hexcode of a color I want (for example #0055CC) when I tried to paint pipes. It just breaks and autofills another color.
-
When searching for specific tiles, the scrolling enus don't show up which is pain since it'll likely be how mappers will be looking for the entire menu and now just all the items spread out (see image)
Instead of
-
While you CAN favorite any kind of tiles, you cannot have one specific item bound to a key. You need to be able to bind some tiles to action keys like before
-
As corrupt said, a mass scanner view.
-
A way to toggle the UI back to regular client on and off especially for testing purposes would be deeply appreciated.
-
Possibly showing the entity ID when hovering over them instead of the same thing, that way you can search for similar items easier
- It's a bit weird the old "copy button" is replaced by a new bind which does the same thing for the "pick entity or tile"
It's some of the issues I've seen while testing, however, it's a massive improvement overall.
5 participants
LICENSE: MIT
About the PR
Ports Reserve-Station/Reserve-Station#82 which is early merge of stale wizden PR, see it for more details.
Mapping simpler now
Media
Quick look:
Mapping templates, disabled rendering of walls, airlocks, markers
How to test
run
mappingcommand, load any map, try messing with menusBreaking changes
Changelog