Allows for items to have unique inspection name

[ta3754859-max]

About The Pull Request

Items have now examine_name variable, if it's set examining somebody through shift+click will give alternate item name (example: you shift click a disguised adept, collar of servitude -> gorget). It only works during that, so normally inspecting the item won't change the name (you're an adept and shift click the collar, the name is still collar of servitude)

Why It's Good For The Game

Allows the inquistion/soon to come Noccites to stay hidden without having to throw away every single item they spawn with. I will change more inquisition items names to be later, but first I need a mantainer to rate the code and decide whether it won't case any lags etc. As it gives every single thing in the game the display_name variable. It's due to that, because get_examine_string, that's used in examination item list, comes from atom class

Note, opening the stripping menu still shows normal item name

Changelog

🆑
code: Framework (if you can even call it that) for alternative examine names
add: alternative naming for inquisition items
fix: Skin items such as disciple's skin no longer show up on examine
/:cl:

Pre-Merge Checklist

• You tested this on a local server.
• This code did not runtime during testing.
• You documented all of your changes.

[PotatoTomahto]

I feel like it would be better to just override specific items examine procs when needed.

[ta3754859-max]

I feel like it would be better to just override specific items examine procs when needed.

Here's the issue, overriding get_examine_string is used while examining an item in itself and the name would show the alternative name. I could make the list use a new function called something like get_examine_list_string that would be only used for overrides.

Current code is the path of least resistance, but it might be unopotimised

[ta3754859-max]

I changed the code to use overrides, not very proud of how the function looks like but it's the best I could do, it's a splice of the get_examine_name and get_examine_string as I would have issues replacing the name otherwise. I think it might be the best way I could have done it, at least I don't see any alternatives

[Ben10083]

I would allow Archivists to be able to tell what the true item is all the time, given they are the 'know it all' role.