Gravetender Rework#6254
Open
The-Awful wants to merge 158 commits intoMonkestation:mainfrom
Open
Conversation
Devotion Helper Procs + DMdoc
Alt Click + Update_Overlay + Misc Fixes
sourceitem fix
…derlin into GravetenderChanges
MORE requested changes
quick possible murderwood fix
Burial Rite Fix
FIX FINAL WORDS
Additional log to try to find fix for gravespawner
The Nuclear Option
Mapgen Exception
Requested Change
instead of src, T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR seeks to rework Gravetender to be a more indepth role, while still intended to be relatively simple, they will be granted new tools with which to encourage RP, both between them, craftsmen, the deceased, and their families. They are also intended to be a more capable at dealing with deadites and skeletons, as they should be the best, or perhaps second best behind necran templars, at doing this. Documented below are the specifics of all changes:
Consecration and its tiers has been reworked into seperate grave quality and consecration. Consecration merely tracks whether a grave has been consecrated via burial rites. Quality tracks the effect that said consecration will have.
Grave decorations, headstones and gravefences, have been added which increase gravequality.
Grave decorations may be crafted with masonry. Higher tier decorations may be smithed.
Graves give a mood buff on examine depending on quality.
Graves give passive devotion to any Gravetenders/Necran Acolytes/Necran Templars.
Graves give higher level curses if disturbed at high quality.
Graves will deliver the "final words" of a spirit, set by going to the underworld, or when present as a spirit and a burial occurs.
Spirits may not reveal who killed them with this.
Graves may receive inscriptions if a headstone is present, in addition to automatically assigning the name of the buried corpse on consecration.
A unique weapon will be granted to Gravetenders, the Necran Battleshovel, it acts as a polearm with chop intent, and a close range strike intent. Specialized for dispatching undead. Also works as a shovel, of course.
Graves will trigger a special Necran flower to bloom nearby on consecration.
Mapped in graves will receive a new loot pool, with intact corpses. So that pestrans can rob them for their organs.
Grave quality is affected as such:
+1-3 for headstones.
+1-3 for gravefences.
+1 for present winding sheet / coffin
+2 if present coffin is consecrated
+1 for burial inside of graveyard
-Penalty for damaged corpse (TBD)
This all maxes out at 10.
Headstones/Fences will get the max bonus of +3 if the corpse buried under them has a matching patron to what they represent.
Passive devotion gain starts at quality 7, at 0.025 devotion gain, increasing by 0.025 for every additional quality after that, maxing out at a passive devotion gain of 0.1 for a quality 10 grave. The total of all graves is how much devotion the Necran gains, though it maxes out at 0.5 per second. Half of the Priest's.
Credits:
Code by me and Ben10083 on discord.
All sprites by me, except, of course, the Necran Battle-shovel which was made by AberrantQuerist.
Why It's Good For The Game
Gravetenders for a long time have been a neglected role, burials can be done by basically anyone, and burying the dead isn't even all that necessary considering the ease of decapitation, and of escaping the underworld. Instead of making these things harder to achieve by non-gravetenders, burials by gravetenders are here instead granted unique features. Gravetenders should be encouraged to maintain their yard, hold services, and stop any pesky graverobbers from messing with their flock. Gravetender has for a long time been seen as a somewhat "chill" role, and here we seek to maintain that, merely granting them more tools that they may choose to interact with.
Changelog
🆑
add: Added new grave quality system. With assistance from ben10083.
add: Refactored and expanded grave robbery curses. With assistance from ben10083.
add: Added decorations for graves.
add: Added new unique weapon for gravetenders. With assistance from AberrantQuerist.
add: Added passive devotion to gravetenders for burial. Credit to ben10083.
add: New grave recipe book given to gravetenders.
add: Grave inscriptions that read the deceased's spirit's parting words. Credit to ben10083.
code: Ported timestop spell from monkestation.
map: closed/loot and gravemarker replaced with gravespawner maphelper. Credit to ben10083.
fix: Fixed exhuming graves not putting clods of dirt on shovels.
fix: fixes runtime relating to descending into Underworld, possibly fixing death arena
image: Added new icons for grave curses.
/:cl:
Pre-Merge Checklist