Filters but useful & Blurry Vision#286
Open
Sun-Soaked wants to merge 5 commits intoMonkestation:masterfrom
Open
Filters but useful & Blurry Vision#286Sun-Soaked wants to merge 5 commits intoMonkestation:masterfrom
Sun-Soaked wants to merge 5 commits intoMonkestation:masterfrom
Conversation
Sun-Soaked
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports
tgstation/tgstation#55246
era tg filter code
Slightly modernized & adapted to our old bay frankencode with pointers from tgmc's code
Thanks tivi
Comments in filter code are preserved from tg and not mine
Tldr:
-Filters are no longer coder torture to use, and have several streamlined procs to add, remove, and generally mess with them
-Adds some default filter type helpers to plug into the filter procs
-Admins can now use a discreet tgui menu to mess with filters ingame
-ports the wibble function(for enhanced wibbling)
-ports true blur for blurriness as a prototype of plane-master filter implementation
-previous "haze" blurriness has been preserved as a new debuff, which is triggered by flashbang, welding without protection, imminent paincrit, and serious blood loss.
Why It's Good For The Game
finally we are only 5 years behind modern filter technology instead of like. 11.
This extremely useful visual tool is almost completely unimplemented on eris because default dm filter stuff is really annoying to use properly
Ideally this'll allow us to use more advanced visual effects like distortions, glowing outlines
Testing
Works
Changelog
🆑
add: Blurriness debuff now actually blurs the screen, using filters.
add: A "hazy" debuff containing previous screen clouding behavior of blurriness
fix: The damage of welding without protection now scales and gives visual effects as intended
code: filters can now be assigned and manipulated with some discrete procs on atom
code: Adds template helpers for different filter operations
admin: adds "filteriffic", tg's tgui interface for admin manipulation of filters ingame. Accessed via the vv menu "edit filters"
/:cl: