fix: admin traitor panel unable to remove traitor status (#222)#280
Open
BartDrown wants to merge 3 commits intoMonkestation:masterfrom
Open
fix: admin traitor panel unable to remove traitor status (#222)#280BartDrown wants to merge 3 commits intoMonkestation:masterfrom
BartDrown wants to merge 3 commits intoMonkestation:masterfrom
Conversation
flleeppyy
reviewed
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR addresses Traitor panel not refreshing after deletion of traitor status,
It also subtracts stats and clears memories per antag role after traitor status deletion.
Enchanced support for doubled up different and same antags eg. two contractor roles on one person, separate uplinks, separate memories, deletion of memories etc.
Right now deleting one antag shouldn't delete other antag uplinks.
Fixed minor issue when accessing headset frequency of uplink that was deleted.
Added additional dialog warning for admin when adding duplicate antag role for the same person.
Added "Your contract has been terminated. You are no longer an operative." when someones contractor status is removed.
Why It's Good For The Game
It improves traitor panel and removes some of the bugs that were haunting said place.
Testing
Tested it on multiple instances of traitors with doubled up same and different anta roles.
Seems to be working properly, according memories after role deletion are cleared, uplinks unusable.
Doubled up antags with stat (starting vigilance value = 16)

Memories and stats after roles removal

Changelog
🆑
fix: Traitor Panel now properly refreshes after removing an antagonist role
fix: Removing an antagonist role now reverses its stat bonuses
fix: Removing contractor status now deletes the contractor's uplink
fix: Removing contractor status now clears related entries from the player's memory
fix: Removing one contractor role no longer removes uplinks belonging to other contractor roles on the same player
fix: Deleting a headset uplink no longer breaks the headset's frequency selection
admin: Adding a duplicate antagonist role now shows a warning prompt
admin: Multiple antagonist roles of the same type are now numbered in the Traitor Panel
/:cl: