Open
Conversation
added 2 commits
February 19, 2019 13:42
rohan-achar
requested changes
Feb 20, 2019
| for delta in self.version_graph[version:]: | ||
| merged = utils.merge_state_delta(merged, delta) | ||
| return merged, [version, self.version_graph.head.current] | ||
| if not merged: |
Member
There was a problem hiding this comment.
You also need to make the equivalent check in Graph class in getitem to return an empty list if the start version does not exist.
| @@ -0,0 +1,96 @@ | |||
| #!/usr/bin/env python3 | |||
Member
There was a problem hiding this comment.
Move this file to SampleApps folder.
rohan-achar
requested changes
Mar 1, 2019
| self.graph = Graph() | ||
| super().__init__() | ||
| self.manager = Manager() | ||
| self.result_manager = Manager() |
Member
There was a problem hiding this comment.
One manager should work. Why so many managers?
…into GraphDebugger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Did the suggested changes-Created a graph actor class which queues up the requests to the version graph class. Made some changes to the full state version manager class so that the version manager keeps track of the version graph head itself.
The word counter application doesn't work i.e. doesn't display any counts after these changes. Looking into it. Created the request just for review.
Pritha