feat: Adding a new SparklineCell view and adding trend lines to the GroupedStat table#392
Merged
Conversation
anthonywongskyboxlabs
approved these changes
Jun 2, 2026
| observedCategories, | ||
| ); | ||
|
|
||
| if (sparklineColumnIndex !== undefined) { |
Contributor
There was a problem hiding this comment.
Wondering if this can ever become false. I see we pass in 0 in ClientEntitySystems.tsx, but does the value of sparklineColumnIndex change afterwards?
Contributor
Author
There was a problem hiding this comment.
Oh yeah, that shouldn't be possible. I did a cleanup pass trying to remove undefined's where possible and think I missed this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new
SparklineCellcontrol which renders a very basic line chart using an SVG polyline, as well as a Min/Max label.The sparklines are being used to render trend lines on each row of the Entity and Systems tables in
Client - Entity SystemsThe logic for driving the trend line is handled within the
MinecraftGroupedStatisticTable, which is also controlling the time window for the history, aggregation of the child rows and some normalizations smoothing to make the graphs easier to read over time.ecs_graphs.mp4