Support for return values other than ints with backwards-compatability#123
Open
SerenaLynas wants to merge 8 commits into
Open
Support for return values other than ints with backwards-compatability#123SerenaLynas wants to merge 8 commits into
SerenaLynas wants to merge 8 commits into
Conversation
M4ximumPizza
previously approved these changes
Dec 4, 2022
M4ximumPizza
left a comment
There was a problem hiding this comment.
Looks good. I would say it would be approved.
For all boxed primitive numeric types, combine now adds them instead of just integers
Author
|
I made minor changes to the new parts in this PR. No other changes were made since @M4ximumPizza's review.
TODO: write tests for the new functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows commands to return any object. Because of Java's autoboxing, it is mostly backwards compatible with older code which returns ints. The only breaking changes are that old user code which references
Command<S>must be changed toCommand<S, Integer>, and the return value from command execution is now Object, so the type needs to be checked/cast to int. Please let me know if there are any other breaking changes. I didn't change the tests aside from adding the Integer generic as mentioned above, so everything else should be the same.I think that many users of this library will find the minimal cost of refactoring worth it given the immense benefit of returning more than just ints.