Add missing calls to fail() when exceptions are expected to be thrown#107
Open
Pokechu22 wants to merge 1 commit into
Open
Add missing calls to fail() when exceptions are expected to be thrown#107Pokechu22 wants to merge 1 commit into
Pokechu22 wants to merge 1 commit into
Conversation
Fixes Mojang#106. Without this, the test could pass if no exception is thrown, in addition to the wanted result of a matching exception being thrown.
JoshuaLim007
approved these changes
Dec 16, 2021
xtexx
approved these changes
Aug 9, 2022
Contributor
|
Closing and reopening to rerun checks. |
Gamebuster19901
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106. Without this, the test could pass if no exception is thrown, in addition to the wanted result of a matching exception being thrown.
fail()is now called before anycatchin test code, as verified bygrep -B1 -r catch src/test/java: