[fix] add visual_infer_batch_size check #980
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @SangChengC, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces crucial input validation checks for visual inference configuration parameters. The primary goal is to prevent runtime errors and ensure stable operation by enforcing correct relationships between visual_dp and visual_infer_batch_size before the system proceeds with potentially invalid settings.
Highlights
- Input Validation for Visual Data Parallelism: I've added a check to ensure that the
visual_dpargument, which likely relates to visual data parallelism, is a positive integer. Ifvisual_dpis less than or equal to zero, aValueErroris now raised. - Configuration Validation for Visual Inference Batch Size: I've implemented a new validation step for
visual_infer_batch_size. This check ensures thatvisual_infer_batch_sizeis a positive integer and is also a perfect multiple ofvisual_dp. If this condition is not met, aValueErroris raised with a descriptive message, guiding users to provide compatible values.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| if args.visual_infer_batch_size // args.visual_dp < 1 or args.visual_infer_batch_size % args.visual_dp != 0: | ||
| raise ValueError( | ||
| f"visual_infer_batch_size ({args.visual_infer_batch_size}) must be " | ||
| f"a positive integer multiple of visual_dp ({args.visual_dp})" | ||
| ) |
There was a problem hiding this comment.
The error message could be improved to provide more context. Consider including the expected relationship between visual_infer_batch_size and visual_dp in the message to help users understand the requirement.
raise ValueError(
f"visual_infer_batch_size ({args.visual_infer_batch_size}) must be a positive integer multiple of visual_dp ({args.visual_dp})."
f" Ensure that visual_infer_batch_size is divisible by visual_dp and that the result is at least 1."
)
No description provided.