IndexUnitWriter with Compress argument defaulted to false#148
Closed
sean7218 wants to merge 1 commit intoMobileNativeFoundation:mainfrom
Closed
IndexUnitWriter with Compress argument defaulted to false#148sean7218 wants to merge 1 commit intoMobileNativeFoundation:mainfrom
sean7218 wants to merge 1 commit intoMobileNativeFoundation:mainfrom
Conversation
sean7218
changed the title
sean7218
force-pushed
the
sean7218/default-false-for-compression
branch
from
60f7ee6 to
456197d
Compare
Member
|
started ci, please fix the dco |
Signed-off-by: Sean Zhang <sean7218@gmail.com>
sean7218
force-pushed
the
sean7218/default-false-for-compression
branch
from
456197d to
31ff3e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Compress argument defaulted to false for IndexUnitWriter constructor.
IndexUnitWriter.cpp
Changes
to false
Context
This change aligns with the Swift LLVM project's IndexUnitWriter implementation by explicitly specifying the
compression parameter. The false value maintains the current behavior while making the compression setting
explicit rather than relying on default parameter values.
Testing