* fixed: ObjC -- concurrency issues in heavy-duty environment #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. There was a classic deadlock with two locks:
* thread A: CUSTOM_OBJECTS, objcBridgeLock
* thread B: objcBridgeLock, CUSTOM_OBJECTS
2. dealloc and CUSTOM_OBJECTS.remove was not atomic, as result
between these two actions, after dealloc another thread might
allocate new peer with same address and inserts into CUSTOM_OBJECTS.
next CUSTOM_OBJECTS will drop not related Java object that will cause
it to be GCed (if not retained anywhere)
3. peers map keeps week reference to objects. as result due GC it got wiped.
this lead to bug in scenario native-to-jave call that `getPeerObject` is not
able to find Java object and it is being allocated. This is an issue for
custom classes where Java object keeps state. In this case it is being lost
as blank object is created.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPeerObjectis not able to find Java object and it is being allocated. This is an issue for custom classes where Java object keeps state. In this case it is being lost as blank object is created.