Skip to content

[fix] 몽고디비에 UTC 시각으로 저장되지않는 문제를 해결한다 #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alsdddk merged 4 commits into from
Dec 21, 2025
Merged

[fix] 몽고디비에 UTC 시각으로 저장되지않는 문제를 해결한다 #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97a7e69
refactor: instant로 변경
alsdddk Dec 6, 2025
87fb0d4
refactor: 모집기간을 start/end로 분리
alsdddk Dec 10, 2025
7cdd077
refactor: 테스트에도 Instant적용
alsdddk Dec 12, 2025
806f92d
test: 테스트격리를 위해 데이터 정리 로직 추가(중복 토큰 방지)
alsdddk Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/src/main/java/moadong/club/entity/ClubRecruitmentInformation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import jakarta.persistence.Id;
import jakarta.validation.constraints.NotNull;
import jakarta.validation.constraints.Pattern;

import java.time.Instant;
import java.time.LocalDateTime;
import java.time.ZoneId;
import java.time.ZonedDateTime;
Expand Down Expand Up @@ -49,9 +51,9 @@ public class ClubRecruitmentInformation {
@Column(length = 13)
private String presidentTelephoneNumber;

private LocalDateTime recruitmentStart;
private Instant recruitmentStart;

private LocalDateTime recruitmentEnd;
private Instant recruitmentEnd;

private String recruitmentTarget;

Expand Down
14 changes: 9 additions & 5 deletions backend/src/main/java/moadong/club/payload/dto/ClubDetailedResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public record ClubDetailedResult(
String description,
String presidentName,
String presidentPhoneNumber,
String recruitmentPeriod,
String recruitmentStart,
String recruitmentEnd,
String recruitmentTarget,
String recruitmentStatus,
String externalApplicationUrl,
Expand All @@ -34,12 +35,14 @@ public record ClubDetailedResult(
) {

public static ClubDetailedResult of(Club club, List<ClubSearchResult> recommendClubs) {
String period = "미정";
ClubRecruitmentInformation clubRecruitmentInformation = club.getClubRecruitmentInformation();

String start = "미정";
String end = "미정";
if (clubRecruitmentInformation.hasRecruitmentPeriod()) {
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy.MM.dd HH:mm");
period = clubRecruitmentInformation.getRecruitmentStart().format(formatter) + " ~ "
+ clubRecruitmentInformation.getRecruitmentEnd().format(formatter);
start = clubRecruitmentInformation.getRecruitmentStart().format(formatter);
end = clubRecruitmentInformation.getRecruitmentEnd().format(formatter);
}

String lastModifiedDate = "";
Expand Down Expand Up @@ -70,7 +73,8 @@ public static ClubDetailedResult of(Club club, List<ClubSearchResult> recommendC
.presidentPhoneNumber(
clubRecruitmentInformation.getPresidentTelephoneNumber() == null ? ""
: clubRecruitmentInformation.getPresidentTelephoneNumber())
.recruitmentPeriod(period)
.recruitmentStart(start)
.recruitmentEnd(end)
.recruitmentTarget(clubRecruitmentInformation.getRecruitmentTarget() == null ? ""
: clubRecruitmentInformation.getRecruitmentTarget())
.recruitmentStatus(clubRecruitmentInformation.getClubRecruitmentStatus() == null
Expand Down
5 changes: 3 additions & 2 deletions backend/src/main/java/moadong/club/payload/request/ClubRecruitmentInfoUpdateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
package moadong.club.payload.request;

import java.time.Instant;
import java.time.LocalDateTime;
import java.util.List;
import moadong.club.entity.Faq;

public record ClubRecruitmentInfoUpdateRequest(
LocalDateTime recruitmentStart,
LocalDateTime recruitmentEnd,
Instant recruitmentStart,
Instant recruitmentEnd,
Comment on lines +9 to +10
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cat -n backend/src/main/java/moadong/club/payload/request/ClubRecruitmentInfoUpdateRequest.java | head -30

Repository: Moadong/moadong

Length of output: 551

🏁 Script executed:

rg -nP --type=java 'ClubRecruitmentInfoUpdateRequest' -A 5 -B 5

Repository: Moadong/moadong

Length of output: 14068

🏁 Script executed:

rg -nP --type=java 'class ClubRecruitmentInformation' -A 40 | head -60

Repository: Moadong/moadong

Length of output: 4038

🏁 Script executed:

sed -n '1,60p' backend/src/main/java/moadong/club/entity/ClubRecruitmentInformation.java

Repository: Moadong/moadong

Length of output: 1556

Remove the unused LocalDateTime import from the DTO.

The DTO's Instant type parameters correctly align with the entity's Instant fields, and all controller, service, and entity code properly handles the type. However, line 4 imports LocalDateTime but it's never used—remove this dead import for cleaner code.

🤖 Prompt for AI Agents 
In
backend/src/main/java/moadong/club/payload/request/ClubRecruitmentInfoUpdateRequest.java
around lines 9-10, remove the unused import of java.time.LocalDateTime
(currently on line 4) since the DTO uses Instant; delete the dead import and
re-run your IDE's organize imports or build (mvn/gradle) to ensure no remaining
unused imports and that the file compiles.

String recruitmentTarget,
String description,
String externalApplicationUrl,
Expand Down
2 changes: 2 additions & 0 deletions backend/src/main/java/moadong/fcm/repository/FcmTokenRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@

public interface FcmTokenRepository extends MongoRepository<FcmToken, String> {
Optional<FcmToken> findFcmTokenByToken(String fcmToken);
void deleteFcmTokenByToken(String fcmToken);

}
1 change: 1 addition & 0 deletions backend/src/test/java/moadong/fcm/service/FcmServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public TaskExecutor taskExecutor() {

@BeforeEach
void setUp() {
fcmTokenRepository.deleteFcmTokenByToken("existing_token");
club1 = clubRepository.save(Club.builder().name("club1").build());
club2 = clubRepository.save(Club.builder().name("club2").build());
club3 = clubRepository.save(Club.builder().name("club3").build());
Expand Down
6 changes: 4 additions & 2 deletions backend/src/test/java/moadong/fixture/ClubRequestFixture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
import moadong.club.payload.request.ClubInfoRequest;
import moadong.club.payload.request.ClubRecruitmentInfoUpdateRequest;

import java.time.Instant;
import java.time.LocalDateTime;
import java.time.temporal.ChronoUnit;
import java.util.List;
import java.util.Map;

Expand All @@ -26,8 +28,8 @@ public static ClubInfoRequest createValidClubInfoRequest() {

public static ClubRecruitmentInfoUpdateRequest defaultRequest() {
return new ClubRecruitmentInfoUpdateRequest(
LocalDateTime.now(),
LocalDateTime.now().plusDays(7),
Instant.now(),
Instant.now().plus(7, ChronoUnit.DAYS),
"테스트 대상",
"테스트 설명",
"https://fake-url.com",
Expand Down
Loading