Skipping transaction sync #5718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a check to skip transaction synchronization when the destination address does not exist in the local database. The change prevents unnecessary database operations for addresses that are not tracked locally.
Key changes:
- Added validation to check if address exists before syncing transactions
- Early return mechanism to skip sync for non-existent addresses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RefreshWeb3TransactionsJob.kt | Added address existence check before inserting transactions |
| Web3AddressDao.kt | Added new query method to check if address exists in database |
Comment on lines
+57
to
+60
| if (!web3AddressDao.addressMatch(destination)) { | ||
| Timber.d("Address $destination does not exist in local database, skipping transaction sync") | ||
| return@requestRouteAPI null | ||
| } |
There was a problem hiding this comment.
The address existence check is performed after fetching transactions from the API. Consider moving this check before the API call to avoid unnecessary network requests for non-existent addresses.
Suggested change
| if (!web3AddressDao.addressMatch(destination)) { | |
| Timber.d("Address $destination does not exist in local database, skipping transaction sync") | |
| return@requestRouteAPI null | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.