-
Notifications
You must be signed in to change notification settings - Fork 109
Update word check #5232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SeniorZhai
wants to merge
2
commits into
master
Choose a base branch
from
opt/mnemonic_phrase_input
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update word check #5232
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -77,6 +77,7 @@ import one.mixin.android.tip.Tip | |||||
| import one.mixin.android.ui.home.web3.swap.KeyboardAwareBox | ||||||
| import one.mixin.android.ui.wallet.WalletViewModel | ||||||
| import one.mixin.android.util.getMixinErrorStringByCode | ||||||
| import org.bitcoinj.crypto.MnemonicCode | ||||||
|
|
||||||
| @Composable | ||||||
| fun MnemonicPhraseInput( | ||||||
|
|
@@ -283,6 +284,12 @@ fun MnemonicPhraseInput( | |||||
| ) | ||||||
| } | ||||||
| } else { | ||||||
| val text = inputs[index] | ||||||
| val textColor = if (index != focusIndex && text.isNotEmpty() && MnemonicCode.INSTANCE.wordList.contains(text).not()) { | ||||||
| MixinAppTheme.colors.tipError | ||||||
| } else { | ||||||
| MixinAppTheme.colors.textMinor | ||||||
| } | ||||||
| BasicTextField( | ||||||
| modifier = Modifier.onFocusChanged { focusState -> | ||||||
| focusIndex = if (focusState.isFocused) { | ||||||
|
|
@@ -300,7 +307,7 @@ fun MnemonicPhraseInput( | |||||
| singleLine = true, | ||||||
| cursorBrush = SolidColor(MixinAppTheme.colors.accent), | ||||||
| textStyle = LocalTextStyle.current.copy( | ||||||
| color = MixinAppTheme.colors.textMinor, | ||||||
| color = textColor, | ||||||
| fontSize = 13.sp, | ||||||
| fontWeight = W500 | ||||||
| ), | ||||||
|
|
@@ -398,7 +405,7 @@ fun MnemonicPhraseInput( | |||||
| Row { | ||||||
| Text( | ||||||
| "${index + 1}", | ||||||
| color = MixinAppTheme.colors.textPrimary, | ||||||
| color = textColor, | ||||||
| fontSize = 13.sp, | ||||||
| ) | ||||||
| Spacer(Modifier.width(8.dp)) | ||||||
|
|
@@ -557,7 +564,6 @@ fun MnemonicPhraseInput( | |||||
| ) | ||||||
| Spacer(modifier = Modifier.height(8.dp)) | ||||||
| } | ||||||
|
|
||||||
| if (errorInfo.isNotBlank()) { | ||||||
| Spacer(modifier = Modifier.height(8.dp)) | ||||||
| Text( | ||||||
|
|
@@ -566,14 +572,22 @@ fun MnemonicPhraseInput( | |||||
| color = MixinAppTheme.colors.tipError, | ||||||
| ) | ||||||
| Spacer(modifier = Modifier.height(8.dp)) | ||||||
| } else if (inputs.any { it.isNotEmpty() && MnemonicCode.INSTANCE.wordList.contains(it).not() }) { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This validation logic iterates through all inputs and performs word list lookups on each composition. This could be expensive with many input fields. Consider memoizing this validation or moving it to a computed property.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| Spacer(modifier = Modifier.height(8.dp)) | ||||||
| Text( | ||||||
| modifier = Modifier.align(Alignment.Start), | ||||||
| text = context.getString(R.string.invalid_mnemonic_phrase), fontSize = 14.sp, | ||||||
| color = MixinAppTheme.colors.tipError, | ||||||
| ) | ||||||
| Spacer(modifier = Modifier.height(8.dp)) | ||||||
| } | ||||||
| Spacer(modifier = Modifier.height(if (legacy) 20.dp else 8.dp)) | ||||||
| Spacer(modifier = Modifier.weight(1f)) | ||||||
| Button( | ||||||
| modifier = Modifier | ||||||
| .fillMaxWidth() | ||||||
| .height(48.dp), | ||||||
| enabled = state == MnemonicState.Display || inputs.all { it.isNotEmpty() }, | ||||||
| enabled = state == MnemonicState.Display || (inputs.all { it.isNotEmpty() && MnemonicCode.INSTANCE.wordList.contains(it) }), | ||||||
| onClick = { | ||||||
| val words = inputs.map { it.trim() } | ||||||
| validate?.invoke(words)?.let { | ||||||
|
|
@@ -634,7 +648,7 @@ fun MnemonicPhraseInput( | |||||
| }, | ||||||
| colors = | ||||||
| ButtonDefaults.outlinedButtonColors( | ||||||
| backgroundColor = if (state == MnemonicState.Display || inputs.all { it.isNotEmpty() }) { | ||||||
| backgroundColor = if (state == MnemonicState.Display || (inputs.all { it.isNotEmpty() && MnemonicCode.INSTANCE.wordList.contains(it) })) { | ||||||
| MixinAppTheme.colors.accent | ||||||
| } else { | ||||||
| MixinAppTheme.colors.backgroundGray | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word list lookup
MnemonicCode.INSTANCE.wordList.contains(text)is being called multiple times for the same text during composition. Consider caching the validation result or extracting it to avoid redundant lookups.Copilot uses AI. Check for mistakes.