style: clear pre-existing lint and gofmt debt - #653
Open
james-nesbitt wants to merge 1 commit into
Open
Conversation
golangci-lint reported 5 pre-existing issues on main and three files were not gofmt-clean. None are functional changes. golangci-lint (now 0 issues): - pkg/product/mke/config/cluster_spec.go: double blank line (gci) - pkg/product/mke/config/host.go: formatting (gci) - pkg/configurer/windows.go: blank line after the InstallMCR opening brace (gofumpt, whitespace) - pkg/docker/image.go: rename 'wp' -> 'pool' (varnamelen); matches the name already used on the rig v2 migration branch gofmt (not caught by make lint, which sets run.tests: false): - pkg/product/mke/phase/validate_facts_test.go, test/platforms.go, test/smoke/smoke_test.go: field alignment and a trailing blank line Written by AI: claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clear pre-existing lint and
gofmtdebt onmain. No functional changes.Why
make lintcurrently fails onmainwith 5 issues, and three files are notgofmt-clean. This is unrelated to any feature work — it just means anyone runningmake lintlocally starts from a red baseline, and new violations are easy to miss in the noise.How
golangci-lint(5 → 0 issues):pkg/product/mke/config/cluster_spec.go— double blank line inUnmarshalYAML(gci)pkg/product/mke/config/host.go— formatting (gci)pkg/configurer/windows.go— stray blank line after theInstallMCRopening brace (gofumpt,whitespace); leftover from [PRODENG-3471] Fix Windows MCR install failing on FIPS channels #640 removingversion := "latest"pkg/docker/image.go— renamewp→pool(varnamelen). Deliberately matches the name already used on the rig v2 migration branch, so that rebase stays clean.gofmt(not covered bymake lint, which setsrun.tests: false):pkg/product/mke/phase/validate_facts_test.go,test/platforms.go,test/smoke/smoke_test.go— struct field alignment and one trailing blank lineEverything except the
wp→poolrename was applied bygolangci-lint run --fix/gofmt -w; the rename was done via LSP so all three references moved together.Testing
make lint→ 0 issuesgofmt -lacross./pkg ./cmd ./test .→ cleango build ./...,go vet ./..., andgo vet -tags=integration ./test/...all passgo test ./pkg/...passesLinks
Checklist
Written by AI: claude-sonnet-5