Fix OBJ Material Legacy Mapping by AmberIsFrozen · Pull Request #18 · Minecraft-Transit-Railway/Minecraft-Mappings

AmberIsFrozen · 2026-02-20T12:56:41Z

Change them to comply with NTE

Copilot

Pull request overview

Updates OBJ material “legacy” shader tag mapping across Fabric/Forge and multiple Minecraft versions to align with the NTE naming scheme.

Changes:

Add support for exteriortranslucent -> TRANSLUCENT.
Replace legacy tag handling from underscored forms to non-underscored forms (lighttranslucent, interiortranslucent).
Apply the same mapping updates across all supported Fabric/Forge mapping modules.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
forge/1.20.4-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
forge/1.20.1-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
forge/1.19.4-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
forge/1.19.2-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
forge/1.18.2-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
forge/1.17.1-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
fabric/1.20.4-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
fabric/1.20.1-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
fabric/1.19.4-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
fabric/1.19.2-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
fabric/1.18.2-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.
fabric/1.17.1-mapping/src/main/java/org/mtr/mapping/render/obj/ObjModelLoader.java	Updates legacy shader tag string-to-ShaderType mapping cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-21T16:07:53Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:53Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:53Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:54Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:54Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:55Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:55Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:55Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:55Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

Copilot · 2026-02-21T16:07:56Z

 	private static OptimizedModel.ShaderType legacyMapping(String type) {
 		switch (type.toLowerCase(Locale.ENGLISH)) {
+			case "exteriortranslucent":
+				return OptimizedModel.ShaderType.TRANSLUCENT;
 			case "light":


legacyMapping dropped support for legacy material tags like always_on_light and interior_translucent; those inputs will now fall back to CUTOUT and change rendering for existing OBJ/MTL content. If this method is meant to preserve backward compatibility, keep the old case labels as aliases (e.g., map always_on_light -> TRANSLUCENT_GLOWING and interior_translucent -> TRANSLUCENT_BRIGHT, and optionally accept both underscored and non-underscored variants).

For backward compatibility, we don't know how many of these models are out there already...

Fix OBJ Material Legacy Mapping

054f2ec

zbx1425 requested a review from Copilot February 21, 2026 16:04

Copilot started reviewing on behalf of zbx1425 February 21, 2026 16:04 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Add back original material keys

040fb61

For backward compatibility, we don't know how many of these models are out there already...

jonafanho merged commit 0d4a20b into Minecraft-Transit-Railway:rewrite Apr 5, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix OBJ Material Legacy Mapping#18

Fix OBJ Material Legacy Mapping#18
jonafanho merged 2 commits into
Minecraft-Transit-Railway:rewritefrom
AmberIsFrozen:fix-4

AmberIsFrozen commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

AmberIsFrozen commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants