Fix expireAfter placement in NAP disruption documentation - #462
Open
Ahmed Muhi (ahmedmuhi) wants to merge 1 commit into
Open
Fix expireAfter placement in NAP disruption documentation#462Ahmed Muhi (ahmedmuhi) wants to merge 1 commit into
Ahmed Muhi (ahmedmuhi) wants to merge 1 commit into
Conversation
Contributor
|
Ahmed Muhi (@ahmedmuhi) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
1 similar comment
Contributor
|
Ahmed Muhi (@ahmedmuhi) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit f37412e: ✅ Validation status: passed
For more details, please refer to the build report. |
Contributor
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NAP disruption article currently places
expireAfterunderspec.disruption, but Karpenter v1 defines the field underspec.template.spec.PR #361 previously corrected the same Karpenter v1 field placement in the NAP
NodePool documentation.
This change updates the remaining affected field reference and YAML examples
in the disruption article.
Upstream reference:
https://karpenter.sh/docs/concepts/nodepools/#spectemplatespecexpireafter