Skip to content

[ci-test] PR-F SESSION_COOKIE_DOMAIN — fork CI sandbox #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelUray wants to merge 2 commits into from
Closed

[ci-test] PR-F SESSION_COOKIE_DOMAIN — fork CI sandbox #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0ffb0b
Simplify create card popup (#10926)
BykhovDenis Jun 24, 2026
983afa0
feat(authProviders): SESSION_COOKIE_DOMAIN env var for cross-subdomai…
MichaelUray May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
210 changes: 10 additions & 200 deletions plugins/card-resources/src/components/CreateCardPopup.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,13 @@
<!-- limitations under the License. -->

<script lang="ts">
import card, { Card, CardSpace, MasterTag } from '@hcengineering/card'
import presentation, { getClient, getCommunicationClient, SpaceSelector } from '@hcengineering/presentation'
import { createEventDispatcher } from 'svelte'
import core, { Data, generateId, Ref, Markup, notEmpty, getCurrentAccount } from '@hcengineering/core'
import { getResource, translate, getEmbeddedLabel } from '@hcengineering/platform'
import { Label, Modal, ModernEditbox, languageStore, showPopup, Component } from '@hcengineering/ui'
import { AttachmentStyledBox } from '@hcengineering/attachment-resources'
import card, { CardSpace, MasterTag } from '@hcengineering/card'
import { getClient } from '@hcengineering/presentation'
import { Ref, Markup } from '@hcengineering/core'
import { EmptyMarkup } from '@hcengineering/text'
import { Employee, getCurrentEmployee } from '@hcengineering/contact'
import { SelectUsersPopup, employeeByIdStore, permissionsStore } from '@hcengineering/contact-resources'
import view from '@hcengineering/view'

import { createCard } from '../utils'
import CardCollaborators from './CardCollaborators.svelte'
import { TypeSelector } from '../index'
import { canCreateObject } from '@hcengineering/view-resources'
import CreateCardPopupFull from './CreateCardPopupFull.svelte'
import CreateCardPopupSimple from './CreateCardPopupSimple.svelte'

export let title: string = ''
export let type: Ref<MasterTag> = card.types.Document
Expand All @@ -36,12 +27,8 @@
export let allowChangeSpace: boolean = true
export let description: Markup = EmptyMarkup

const dispatch = createEventDispatcher()
const client = getClient()
const hierarchy = client.getHierarchy()
const communicationClient = getCommunicationClient()
const me = getCurrentEmployee()
const _id = generateId<Card>()

$: extension =
type != null
Expand All @@ -50,187 +37,10 @@
.findAllSync(card.mixin.CreateCardExtension, {})
.find((it) => hierarchy.isDerived(type, it._id))
: undefined

let data: Partial<Data<Card>> = { title }
let _space: Ref<CardSpace> | undefined = space
let collaborators: Ref<Employee>[] = [me]

let creating = false

async function addCollaborators (): Promise<void> {
if (type == null) return
const accounts = collaborators
.filter((it) => it !== me)
.map((it) => $employeeByIdStore.get(it)?.personUuid)
.filter(notEmpty)

if (accounts.length > 0) {
await communicationClient.addCollaborators(_id, type, accounts)
}
}

async function okAction (): Promise<void> {
if (_space === undefined || type == null) return

try {
creating = true

if (extension?.canCreate != null) {
const fn = await getResource(extension.canCreate)
const res = await fn(_space, data)
if (res === false) {
dispatch('close')
return
} else if (typeof res === 'string') {
dispatch('close', res)
return
}
}

await createCard(type, _space, data, description, _id)
await addCollaborators()

dispatch('close', _id)
} finally {
creating = false
}
}

function handleCancel (): void {
dispatch('close')
}

let label: string = ''

$: void updateLabel($languageStore)

async function updateLabel (lang: string): Promise<void> {
const _clazz = hierarchy.getClass(type)
const typeString = await translate(_clazz.label, {}, lang)
const createString = await translate(presentation.string.Create, {}, lang)
label = `${createString} ${typeString}`
}

function openSelectUsersPopup (): void {
showPopup(
SelectUsersPopup,
{
okLabel: presentation.string.Ok,
disableDeselectFor: [me],
skipCurrentAccount: false,
skipInactive: true,
selected: collaborators,
showStatus: true
},
'top',
(result?: Ref<Employee>[]) => {
if (result != null) {
collaborators = result
}
}
)
}

function handleChange (event: CustomEvent<{ data: Partial<Data<Card>>, space?: Ref<CardSpace> }>): void {
data = {
...data,
...event.detail.data
}

if (event.detail.space != null) {
_space = event.detail.space
}
}

$: allowed = _space != null && canCreateObject(type, _space, $permissionsStore)
</script>

<Modal
label={getEmbeddedLabel(label)}
type="type-popup"
width="large"
okLabel={presentation.string.Create}
{okAction}
okLoading={creating}
canSave={data.title != null && data.title.trim().length > 0 && _space != null && allowed}
onCancel={handleCancel}
maxWidth="90vw"
on:close
>
<div class="hulyModal-content__titleGroup" style="padding: 0">
<ModernEditbox
bind:value={data.title}
label={view.string.Title}
size="medium"
kind="ghost"
disabled={extension?.disableTitle ?? false}
autoFocus={!(extension?.disableTitle ?? false)}
/>

<AttachmentStyledBox
objectId={_id}
_class={type}
space={_space}
alwaysEdit
showButtons={false}
bind:content={description}
placeholder={core.string.Description}
kind="indented"
isScrollable={true}
kitOptions={{ reference: true }}
enableAttachments={false}
/>
</div>

<div class="hulyModal-content__settingsSet">
{#if changeType}
<div class="hulyModal-content__settingsSet-line">
<span class="label"><Label label={card.string.MasterTag} /></span>
<TypeSelector bind:value={type} />
</div>
{/if}
{#if (space == null || allowChangeSpace) && !(extension?.hideSpace ?? false)}
<div class="hulyModal-content__settingsSet-line">
<span class="label"><Label label={core.string.Space} /></span>
<SpaceSelector
_class={card.class.CardSpace}
query={{
archived: false,
members: getCurrentAccount().uuid
}}
label={core.string.Space}
bind:space={_space}
focus={false}
clearInvalidValue={true}
kind={'regular'}
size={'large'}
/>
</div>
{/if}

<CardCollaborators
ids={collaborators}
disableRemoveFor={[me]}
on:add={openSelectUsersPopup}
on:remove={(ev) => {
collaborators = collaborators.filter((id) => id !== ev.detail)
}}
/>

{#if extension?.component}
<Component is={extension.component} props={{ collaborators, data, space: _space }} on:change={handleChange} />
{/if}
</div>

<div slot="afterContent" class="error p-4 flex-row-reverse">
{#if !allowed}
<Label label={view.string.NoCreatePermissionTitle} />
{/if}
</div>
</Modal>

<style lang="scss">
.error {
color: var(--theme-error-color);
}
</style>
{#if extension != null}
<CreateCardPopupFull {title} {type} {space} {changeType} {allowChangeSpace} {description} on:close />
{:else}
<CreateCardPopupSimple {title} {type} {space} {description} on:close />
{/if}
Loading
Loading