Skip to content

chore: angular 22 upgrade#84

Merged
MichaelDoyle merged 1 commit into
mainfrom
angular-22
Jun 17, 2026
Merged

chore: angular 22 upgrade#84
MichaelDoyle merged 1 commit into
mainfrom
angular-22

Conversation

@MichaelDoyle

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the workspace to Angular v22 and migrates the testing framework from Karma to Vitest. Feedback on these changes includes adding the missing "runner": "vitest" option to the library's test target, using a fully qualified target name for buildTarget, and removing "vitest/globals" from the root tsconfig.json to prevent leaking test globals into production. Additionally, it is recommended to avoid duplicating the suppression of extended diagnostics across multiple configuration files, and instead centralize or remove these overrides.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread angular.json
Comment thread angular.json Outdated
Comment thread tsconfig.json
Comment thread projects/demo/tsconfig.app.json Outdated
@MichaelDoyle MichaelDoyle force-pushed the angular-22 branch 3 times, most recently from 44334be to 3bf89cc Compare June 16, 2026 03:33
@MichaelDoyle MichaelDoyle merged commit 8509df4 into main Jun 17, 2026
2 checks passed
@MichaelDoyle MichaelDoyle deleted the angular-22 branch June 17, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant