-
Notifications
You must be signed in to change notification settings - Fork 4
add: settings menu and locomotion turn script. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…made buttons a prefab for easier usage.
Sourcery 评审指南此拉取请求添加了一个脚本来控制用于移动的转向类型。该脚本允许通过启用和禁用相应的转向提供程序来在连续转向和捕捉转向之间切换。 未生成图表,因为更改看起来很简单,不需要可视化表示。 文件级别更改
提示和命令与 Sourcery 交互
自定义您的体验访问您的 仪表板 以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request adds a script to control the type of turning used for locomotion. The script allows switching between continuous and snap turning by enabling and disabling the corresponding turn providers. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @claireoni - 我已经查看了你的更改 - 这里有一些反馈:
总体评论:
- 考虑为新脚本使用比
SetTurnType
更具描述性的名称。 - 可以通过使用枚举而不是整数索引来改进
SetTypeFromIndex
函数。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我更有用!请点击每个评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @claireoni - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more descriptive name than
SetTurnType
for the new script. - The
SetTypeFromIndex
function could be improved by using an enum instead of an integer index.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
好的,这是翻译成中文的 pull request 总结:
Sourcery 总结
添加设置菜单和一个移动转向脚本,允许用户选择他们喜欢的转向方式(瞬间转向或连续转向)。
新功能:
Original summary in English
Summary by Sourcery
Adds a settings menu and a locomotion turn script to allow users to select their preferred turning method (snap turn or continuous turn).
New Features: