Test on all supported PHP versions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPCS throws "Cannot assign null to property SlevomatCodingStandard\Sniffs\Namespaces\ReferenceUsedNamesOnlySniff::$namespacesRequiredToUse of type array in [...]php_codesniffer/src/Ruleset.php:1669" Having it empty equals to not setting it at all, I think: https://github.com/slevomat/coding-standard/blob/master/doc/namespaces.md#slevomatcodingstandardnamespacesreferenceusednamesonly-
spaze
force-pushed
the
spaze/php-tests
branch
from
6fdab94 to
dc11d05
Compare
…ned false PHPStan says: > Strict comparison using === between non-empty-string and false will always evaluate to false. but not on PHP 7.4. Removing the `=== false` comparison then throws errors on PHP 7.4. Another option would be to drop 7.4 support :-)
spaze
force-pushed
the
spaze/php-tests
branch
2 times, most recently
from
2de4730 to
33ced32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are green now for all PHP versions.
Had to ignore one more PHPStan error because
substr()doesn't returnfalseanymore on PHP 8.x. The ignore can be removed once PHP 7.4 support is dropped.