feat: added partners properties field #21
Merged
+395
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 23, 2026 11:49
timdah
requested changes
Jan 26, 2026
Collaborator
timdah
left a comment
timdah
left a comment
There was a problem hiding this comment.
Maybe a bit nit picky with the test names, but it should describe what to expect I guess.
The rest LGTM.
src/test/java/com/metaformsystems/redline/api/controller/TenantControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/metaformsystems/redline/domain/service/TenantServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/metaformsystems/redline/domain/service/TenantServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/metaformsystems/redline/domain/service/TenantServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/metaformsystems/redline/domain/service/TenantServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Of course, you’re absolutely right — sorry!! I’ll fix it right away. thanks! |
…tControllerIntegrationTest.java Of course, you’re absolutely right — sorry about that! I’ll fix it right away. Co-authored-by: Tim Dahlmanns <13997715+timdah@users.noreply.github.com>
…tServiceIntegrationTest.java fix: test naming Co-authored-by: Tim Dahlmanns <13997715+timdah@users.noreply.github.com>
…tServiceIntegrationTest.java fix: test naming Co-authored-by: Tim Dahlmanns <13997715+timdah@users.noreply.github.com>
…tServiceIntegrationTest.java fix: test naming Co-authored-by: Tim Dahlmanns <13997715+timdah@users.noreply.github.com>
…tServiceIntegrationTest.java fix: test naming Co-authored-by: Tim Dahlmanns <13997715+timdah@users.noreply.github.com>
timdah
approved these changes
Jan 26, 2026
Contributor
|
@enryp I gave you write permission to the repo. Since this has been approved, can you squash and merge the PR? |
Collaborator
Author
|
@jimmarino I see, thanks for the permissions!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paullatzelsperger
@jimmarino
@wolf4ood
Tried adding the properties column and its handling in dataspace_info_partners.
Tried adding partner creation