Add docstrings and improve readability to make the source code more welcoming to newcomers.#122
Open
JVanloofsvelt wants to merge 14 commits intoMetacoSA:masterfrom
Open
Add docstrings and improve readability to make the source code more welcoming to newcomers.#122JVanloofsvelt wants to merge 14 commits intoMetacoSA:masterfrom
JVanloofsvelt wants to merge 14 commits intoMetacoSA:masterfrom
Conversation
JVanloofsvelt
commented
Jan 26, 2021
| { | ||
| var address = (WhatIsAddress)b58; | ||
| await TryFetchRedeemOrPubKey(address); | ||
| await TryFetchRedeemOrPubKey(address); // Shouldn't the return value here be checked? |
Author
There was a problem hiding this comment.
@NicolasDorier Can you shed some light on this please?
Contributor
There was a problem hiding this comment.
No, TryFetchRedeemOrPubKey is populating address.
Contributor
|
Will review it, that said, I advise you to use https://github.com/dgarage/NBxplorer instead of this project. This project is a full block explorer which is rarely actually needed. NBXplorer works on pruned node because it does not index everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know your opinion on the kinds of changes I'm proposing here. If you're happy with my contribution, then you may leave the pull request open until I've added more changes.