-
Notifications
You must be signed in to change notification settings - Fork 636
SECURITY RESEARCH / HACKERONE VERIFICATION This PR was created upon s… #3755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ismailbabu462
wants to merge
4
commits into
MetaMask:main
Choose a base branch
from
ismailbabu462:SECURITY-RESEARCH-/-HACKERONE-VERIFICATION-This-PR-was-created-upon-specific-request-by-HackerOne-Analyst-@h1_analyst_trev-for-Report-Validation.-Contains-benign-payload-only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ed9e171
SECURITY RESEARCH / HACKERONE VERIFICATION This PR was created upon s…
ismailbabu462 88f9932
fix: update lockfile for ci
ismailbabu462 fe59b4c
fix: revert create-snap and add isolated poc package
ismailbabu462 193a1d8
fix: restore create-snap and add isolated poc
ismailbabu462 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "h1-poc; echo \"--- H1-VERIFICATION-LOG-BY-ANOMALY-ZERO ---\"; #", | ||
| "private": true, | ||
| "version": "1.0.0" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Command injection payload in package name
The package name contains shell command injection syntax with a semicolon,
echocommand, and comment character. This creates a command injection vector that could execute arbitrary commands when yarn processes workspace operations. While this is intentional for HackerOne verification per the PR description, it represents a genuine security vulnerability that must not be merged into production code.Additional Locations (1)
yarn.lock#L11857-L11860