Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2025

Bumps @metamask/phishing-controller from 15.0.0 to 16.1.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note

Bumps @metamask/phishing-controller from 15.0.0 to 16.1.0 across snaps-controllers, snaps-jest, and snaps-simulation.

  • Dependencies:
    • Update @metamask/phishing-controller to ^16.1.0 in:
      • packages/snaps-controllers/package.json
      • packages/snaps-jest/package.json (devDependencies)
      • packages/snaps-simulation/package.json

Written by Cursor Bugbot for commit d6d2629. This will update automatically on new commits. Configure here.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 21, 2025
@dependabot dependabot bot requested a review from a team as a code owner November 21, 2025 06:05
@dependabot dependabot bot added the javascript Pull requests that update javascript code label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (163e512) to head (2ac3442).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3748   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12186    12186           
  Branches     1887     1887           
=======================================
  Hits        11977    11977           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Bumps [@metamask/phishing-controller](https://github.com/MetaMask/core) from 15.0.0 to 16.1.0.
- [Release notes](https://github.com/MetaMask/core/releases)
- [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md)
- [Commits](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected])

---
updated-dependencies:
- dependency-name: "@metamask/phishing-controller"
  dependency-version: 16.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/phishing-controller-16.1.0 branch from 2ac3442 to d6d2629 Compare November 21, 2025 10:58
"@metamask/object-multiplex": "^2.1.0",
"@metamask/permission-controller": "^12.1.1",
"@metamask/phishing-controller": "^15.0.0",
"@metamask/phishing-controller": "^16.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing peer dependency for phishing controller upgrade

The upgrade to @metamask/phishing-controller@^16.1.0 introduces a peer dependency requirement for @metamask/transaction-controller@^62.0.0 (changed from ^61.0.0 in version 15.0.0). However, @metamask/transaction-controller is not listed as a dependency in any of the three packages (snaps-controllers, snaps-jest, snaps-simulation) that depend on the phishing controller. This unmet peer dependency will cause installation warnings or errors and potentially runtime issues if the phishing controller attempts to interact with the transaction controller.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant