Skip to content

Conversation

@jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Nov 24, 2025

Migrates some GH workflows to reusable actions.

follow-up PR of these:

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Migrates CI workflows from reusable workflows to explicit action steps and adds manual dispatch triggers where applicable.

  • Workflows:
    • check-pr-max-lines.yml:
      • Replace reusable workflow with action MetaMask/github-tools/.github/actions/pr-line-check@v1.
      • Add runs-on: ubuntu-latest; configure max-lines and ignore-patterns.
    • flaky-test-report.yml:
      • Replace reusable workflow with action .../flaky-test-report@v1.
      • Add workflow_dispatch; set runs-on; pass repository, workflow-id, github-token, and Slack webhook.
    • post-merge-validation.yml:
      • Replace reusable workflow with action .../post-merge-validation@v1.
      • Add workflow_dispatch; set runs-on; pass repo, start-hour-utc, github-token, and GCP creds.

Written by Cursor Bugbot for commit dc5e870. This will update automatically on new commits. Configure here.

@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 24, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Nov 24, 2025
@jvbriones jvbriones added the skip-e2e skip E2E test jobs label Nov 24, 2025
@jvbriones jvbriones changed the title ci: fix flaky tests report since it was moved from reusable workflow … ci: fix flaky tests report since it was moved to a reusable action Nov 24, 2025
@jvbriones jvbriones changed the title ci: fix flaky tests report since it was moved to a reusable action ci: Migrates some GH workflows to reusable actions Nov 24, 2025
@jvbriones jvbriones requested a review from Mrtenz November 24, 2025 10:57
cmd-ob
cmd-ob previously approved these changes Nov 24, 2025
@jvbriones jvbriones enabled auto-merge November 24, 2025 11:03
yes thanks!

Co-authored-by: Maarten Zuidhoorn <[email protected]>
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

Thanks for taking care of this by the way!

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

The changes in this PR are limited to three GitHub Actions workflow files that handle CI/CD infrastructure tasks:

  1. check-pr-max-lines.yml: Refactored to use a GitHub action directly instead of a reusable workflow for checking PR line limits
  2. flaky-test-report.yml: Refactored to use a GitHub action for generating flaky test reports, plus added manual trigger capability
  3. post-merge-validation.yml: Refactored to use a GitHub action for post-merge validation tracking, plus added manual trigger capability

Why no E2E tests are needed:

  • These are pure CI/CD infrastructure changes that don't modify any application code
  • No changes to the E2E test framework, test execution, or test infrastructure itself
  • No changes to app/core/, controllers, Engine, or any critical application paths
  • The workflows being modified are for monitoring and validation purposes (PR checks, flaky test reporting, post-merge validation)
  • The changes are refactoring how external actions are called (from reusable workflows to direct actions), maintaining the same functionality
  • No impact on user-facing features or wallet functionality

Risk Assessment:

  • Low risk: These are infrastructure-only changes
  • The workflows themselves will validate their own functionality when they run
  • If there are issues with the workflow syntax, they will be caught by GitHub Actions validation before any E2E tests would run
  • The changes don't affect what tests run or how they execute, only how CI/CD jobs are structured

The confidence is high (90%) because the changes are clearly scoped to CI/CD infrastructure with no application code impact. Running E2E tests would not provide meaningful validation of these workflow configuration changes.

View GitHub Actions results

@sonarqubecloud
Copy link

@jvbriones jvbriones added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit f760ae1 Nov 24, 2025
55 checks passed
@jvbriones jvbriones deleted the chore-flaky-tests branch November 24, 2025 11:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-S skip-e2e skip E2E test jobs team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants