chore: remove permitted networks toast - #45442
Open
ameliejyc wants to merge 4 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (4 files, +0 -193)
👨🔧 @MetaMask/core-extension-ux (6 files, +1 -69)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 226c535. Configure here.
Contributor
Builds ready [ec75bd2] [reused from 5ea366b]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs: data not available. |
|
Contributor
Builds ready [4e06939]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 11 warn · 🔴 1 fail)
Bundle size diffs
|
Contributor
Builds ready [4e06939]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 11 warn · 🔴 1 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the new dapp connection UI we are not showing a toast when users switch network.
Changelog
CHANGELOG entry: remove the permitted network toast shown on dapp connection network switch
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-1279
Manual testing steps
The network list menu usage was already not being shown in prod code so cannot test.
Screenshots/Recordings
Before
After
No toast
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only cleanup that drops a toast and its hook; network permission granting itself is unchanged.
Overview
Stops showing the permitted-network toast when a dapp is granted access to a newly selected network from the connection UI.
Deletes the
usePermittedNetworkToasthook and removes its show/dismiss calls from the dapp connection control bar, network selector popover, network list menu, and review-permissions page. Also drops the unusedpermittedChainToastUpdateandeditPermissionslocale strings.Reviewed by Cursor Bugbot for commit 4e06939. Bugbot is set up for automated code reviews on this repo. Configure here.